fix: [project-sequencer-statemachine] editNotesToolIdleStateのupdateCursorStateを修正 #2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigprogramming
requested review from
Hiroshiba
and removed request for
a team
sigprogramming
changed the title
Hiroshiba
approved these changes
Feb 15, 2025
Comment on lines
+110
to
+111
| isCommandOrCtrlKeyDown: boolean, | ||
| isShiftKeyDown: boolean, |
Member
There was a problem hiding this comment.
ここ、仮に関数呼ぶときに逆にしてしまっていてもコンパイルエラーが出ないので、paramsにして引数名を与えないといけない形にしても良いかもですね！
関数呼ぶときちょっと不格好になりますが、
isCommandOrCtrlKeyDown: context.isShiftKeyDown.value
みたいに対応取れてない指定をしたときにすぐ気付ける･････かも！
（勝手に変えさせていただこうかなと思いましたが、updateCursorStateはここ以外にも何箇所かあって方針迷ったので一旦そのままにさせていただきました！）
Hiroshiba
merged commit 2ca944e
into
VOICEVOX:project-sequencer-statemachine
10 checks passed
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
editNotesToolIdleStateのupdateCursorStateを修正します。
関連 Issue
その他