This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Add support for push notifications to our Android app #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wasn't this a requirement for your architecture class that you had to demo? Or did you demo it locally? |
|
Haha, I demoed locally :P Had to anyway in order to simulate a full class opening up a spot. |
|
|
||
| @classmethod | ||
| def delete_expired(cls): | ||
| cls.objects(expiry_date__gt=datetime.datetime.now()).delete() |
There was a problem hiding this comment.
Should it be expiry_date__lt rather than expiry_date__gt?
There was a problem hiding this comment.
Wowwwwww.... oops! And yep, this even includes a poorly-written test to go along with it! 💩
|
@mduan Alright, fixed the issue with the expiry date. Thanks so much for reviewing and catching that!! Anything else? |
|
Other than that, it LGTM. |
... deleting items with expiry dates in the future instead of in the past. Also fix terrible test that did not catch this case. Double oops! Thanks for the catch @mduan!!
divad12
added a commit
that referenced
this pull request
Apr 27, 2014
Add support for push notifications to our Android app
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are push notifications for class seat openings, similar to http://uw.coursealerts.ca/.
Uses Google Cloud Messaging (GCM) to deliver push notifications.
Here's the flow:
/api/v1/alerts/course/gcm.Corresponding PR on Android app: UWFlow/flow-android#45