-
Notifications
You must be signed in to change notification settings - Fork 11
Add support for push notifications on class seat openings #45
base: master
Are you sure you want to change the base?
Conversation
This reverts commit ae4e144. Conflicts: res/layout/course_schedule.xml
... so that we don't have to keep track of what already has an alert.
We've graduated! Yayyy!! Anyone still want to review this? I'll merge in 24 hours if no takers. :) |
I'll review this tmrw — On Sat, Apr 26, 2014 at 10:34 PM, David Hu [email protected]
|
Awesome. :) Now that I know, feel free to take your time. We're adding email notifications for seat openings on web as well now: UWFlow/rmc#124 (by an external contributor, open-source FTW) So it would be cool to have both of these ready for first week of classes and we can announce them together. :) |
String courseId = (bundle == null ? null : bundle.getString(Constants.COURSE_ID_KEY)); | ||
|
||
if (StringUtils.isNotEmpty(courseId)) { | ||
replaceWithFragment(CourseFragment.newInstance(courseId), false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should uncheck any selected nav drawer entries if the app is being opened to a course. Maybe a setAllItemsUnchecked() method?
Some nits, but LGTM. Sorry for the wait. |
Go to "schedule" tab of a course:
Tap the "add alarm" button to add an alarm for a course:
And here's what you see when the notification is sent:
Corresponding server-side changes: UWFlow/rmc#140