Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Conversation

divad12
Copy link
Member

@divad12 divad12 commented Apr 7, 2014

Go to "schedule" tab of a course:

image

Tap the "add alarm" button to add an alarm for a course:

image

And here's what you see when the notification is sent:

image

Corresponding server-side changes: UWFlow/rmc#140

@divad12
Copy link
Member Author

divad12 commented Apr 27, 2014

We've graduated! Yayyy!!

Anyone still want to review this? I'll merge in 24 hours if no takers. :)

@jasperfung
Copy link
Member

I'll review this tmrw


Jasper

On Sat, Apr 26, 2014 at 10:34 PM, David Hu [email protected]
wrote:

We've graduated! Yayyy!!

Anyone still want to review this? I'll merge in 24 hours if no takers. :)

Reply to this email directly or view it on GitHub:
#45 (comment)

@divad12
Copy link
Member Author

divad12 commented Apr 27, 2014

Awesome. :)

Now that I know, feel free to take your time. We're adding email notifications for seat openings on web as well now: UWFlow/rmc#124 (by an external contributor, open-source FTW)

So it would be cool to have both of these ready for first week of classes and we can announce them together. :)

String courseId = (bundle == null ? null : bundle.getString(Constants.COURSE_ID_KEY));

if (StringUtils.isNotEmpty(courseId)) {
replaceWithFragment(CourseFragment.newInstance(courseId), false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should uncheck any selected nav drawer entries if the app is being opened to a course. Maybe a setAllItemsUnchecked() method?

@jasperfung
Copy link
Member

Some nits, but LGTM. Sorry for the wait.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants