Skip to content

cmake: FindIPP fallback #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 30, 2025
Merged

cmake: FindIPP fallback #2148

merged 6 commits into from
Apr 30, 2025

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Apr 24, 2025 •
edited
Loading

  • fallback FindIPP.cmake using default CMake paths
    • finds old & new IPP installations via any method (conda/pip/apt/system etc)
    • required by pip build #2145
  • slightly simplify logic of optional IPP
  • update docs to use IPP_ROOT in lieu of IPP_{INCLUDE,LIBRARY}

@casperdcl casperdcl requested a review from a team as a code owner April 24, 2025 05:10
purepani
purepani reviewed Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@purepani purepani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge without addressing this comment since it can be addressed in a follow-up PR if needed(and I feel like I'm imposing my will on this process a bit too much)

@casperdcl casperdcl mentioned this pull request Apr 24, 2025
Merged
11 tasks
@casperdcl casperdcl self-assigned this Apr 24, 2025
@casperdcl casperdcl requested review from paskino and gfardell and removed request for a team April 24, 2025 07:46
@casperdcl casperdcl added enhancement New feature or request Waiting for review labels Apr 24, 2025
@github-project-automation github-project-automation bot moved this to Todo in CIL work Apr 24, 2025
@casperdcl casperdcl moved this from Todo to Priority review in CIL work Apr 24, 2025
@casperdcl casperdcl changed the title cmake: improved FindIPP cmake: FindIPP fallback Apr 24, 2025
purepani
purepani approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@purepani purepani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casperdcl
Copy link
Member Author

just waiting for a Windows user to test this PR before merging :)

This was referenced Apr 24, 2025
Open
Open
@gfardell
Copy link
Member

Works with my system IPP and with conda-env ipp on windows.

@casperdcl casperdcl merged commit 5ae09cf into master Apr 30, 2025
10 checks passed
@casperdcl casperdcl deleted the find-ipp branch April 30, 2025 05:00
@github-project-automation github-project-automation bot moved this from Priority review to Done in CIL work Apr 30, 2025
casperdcl added a commit that referenced this pull request Apr 30, 2025
@casperdcl
cmake: FindIPP fallback (#2148)
3d0ccd4 
* simple `FindIPP` fallback
* enable `find_package` using `*_ROOT` hints
* simplified `cilacc` build logic for optional dependencies
casperdcl added a commit that referenced this pull request Apr 30, 2025
@casperdcl
cmake: FindIPP fallback (#2148)
967f094 
* simple `FindIPP` fallback
* enable `find_package` using `*_ROOT` hints
* simplified `cilacc` build logic for optional dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purepani purepani purepani approved these changes

@gfardell gfardell gfardell approved these changes

@paskino paskino Awaiting requested review from paskino

Assignees

@casperdcl casperdcl

Labels
enhancement New feature or request Waiting for review
Projects
CIL work
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@casperdcl @gfardell @purepani