Skip to content

Commit aa4f38e

Browse files
committed
Revert "bump cmake to fix docker"
This reverts commit 3d9d9e3.
1 parent 877fc24 commit aa4f38e

File tree

5 files changed

+11
-9
lines changed

5 files changed

+11
-9
lines changed

CMakeLists.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,11 @@
1515
#
1616
# Authors:
1717
# CIL Developers, listed at: https://github.com/TomographicImaging/CIL/blob/master/NOTICE.txt
18-
cmake_minimum_required(VERSION 3.20)
18+
if(APPLE)
19+
cmake_minimum_required(VERSION 3.16)
20+
else()
21+
cmake_minimum_required(VERSION 3.5)
22+
endif()
1923

2024
project(cil LANGUAGES CXX)
2125

recipe/meta.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ requirements:
4242
- pip
4343
- setuptools >=64
4444
- setuptools_scm >=8
45-
- cmake >=3.20
45+
- cmake # [not osx]
46+
- cmake >=3.16 # [osx]
4647
- libgcc-ng # [linux]
4748
- libstdcxx-ng # [linux]
4849
- _openmp_mutex # [linux]

scripts/create_local_env_for_cil_development.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ echo "Environment name $name"
4848
conda_args=(create --name="$name"
4949
python="$python"
5050
numpy="$numpy"
51-
cmake'>=3.20'
51+
cmake'>=3.16'
5252
dxchange
5353
h5py
5454
ipp'>=2021.10'
@@ -99,7 +99,7 @@ else
9999
)
100100
fi
101101

102-
conda "${conda_args[@]}"
102+
conda "${conda_args[@]}"
103103
if [[ -n "${pip_install_pkgs[@]}" ]]; then
104104
python -m pip install "${pip_install_pkgs[@]}"
105-
fi
105+
fi

scripts/requirements-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ dependencies:
2929
- python-wget
3030
- scikit-image
3131
- packaging
32-
- cmake >=3.20
32+
- cmake >=3.16
3333
- setuptools <71
3434
- ipp-include=2021.12
3535
- ipp-devel=2021.12

src/Core/CMakeLists.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
#
1616
# Authors:
1717
# CIL Developers, listed at: https://github.com/TomographicImaging/CIL/blob/master/NOTICE.txt
18-
# Richard Brown (UCL)
19-
2018
set (CMAKE_CXX_STANDARD 11)
2119
set (CMAKE_CXX_STANDARD_REQUIRED ON)
2220
if(NOT DEFINED CMAKE_BUILD_TYPE)
@@ -27,7 +25,6 @@ message ("OpenMP_CXX_FLAGS ${OpenMP_CXX_FLAGS}")
2725
find_package(OpenMP REQUIRED)
2826
add_definitions(${OpenMP_CXX_FLAGS})
2927

30-
3128
if (WIN32)
3229
set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Ddll_EXPORTS")
3330
endif()

0 commit comments

Comments
 (0)