Skip to content

Conversation

litetex
Copy link
Member

@litetex litetex commented Jan 3, 2022

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

@TiA4f8R noticed that #7568 contains a bug:
"the app shows Already playing in background if we switch contents by pressing the background button on the new content when it should show Playing in background"

For now I reverted the PR because better show no information instead of showing a false one 😄

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@litetex litetex added bug Issue is related to a bug GUI Issue is related to the graphical user interface labels Jan 3, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I just noticed my suggestion is equivalent to reverting both #7568 and #7224, i.e. go back to the previous way of showing the toast, i.e. always ;-)

…ature_already-playing-in-backgroud"

This reverts commit ee19ea6, reversing
changes made to 6b490ee.
after feedback from the review
@Stypox Stypox merged commit 1531a51 into TeamNewPipe:dev Jan 23, 2022
@litetex litetex deleted the revert-7568 branch January 23, 2022 15:21
This was referenced Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug GUI Issue is related to the graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants