Skip to content

Conversation

vhouriet
Copy link
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

"Playing in background" toast no longer appear when clicking background if the player is already playing in the background.

Before/After Screenshots/Screen Record

  • Before:
before.mp4
  • After:
after.mp4

Fixes the following issue(s)

This was suggested here : #7202 (review)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@AudricV AudricV changed the title Check if background player already active before displaying " Check if background player already active before displaying player toast Oct 11, 2021
@TobiGr TobiGr added the player Issues related to any player (main, popup and background) label Oct 11, 2021
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@litetex litetex merged commit 9f7a840 into TeamNewPipe:dev Oct 12, 2021
@vhouriet vhouriet deleted the vhouriet_fix_check-background-player-type branch October 21, 2021 13:21
This was referenced Nov 30, 2021
@goyalyashpal
Copy link
Contributor

shouldnt it show "Already playing in background" instead :(
as feedback for an action is important

@vhouriet
Copy link
Contributor Author

shouldnt it show "Already playing in background" instead :( as feedback for an action is important

Yeah sounds good, I'll submit a PR with this small fix.

This was referenced Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

player Issues related to any player (main, popup and background)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants