Skip to content

Conversation

@PulkitGarg67
Copy link
Contributor

@PulkitGarg67 PulkitGarg67 commented Apr 1, 2021

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Functionality to rename Playlist Name from playlist interface

Fixes the following issue(s)

APK testing

On the website the APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@Redirion
Copy link
Member

Redirion commented Apr 1, 2021

thanks for your contribution! However I don't understand why you did basically add doubled code. What was the reason not to use createRenameDialog() ?

Also please refrain from using hardcoded text, use String resources please so that text can be translated.

@AudricV AudricV changed the title Adding functionality to rename Playlist Name from playlist interface … Add functionality to rename Playlist Name from playlist interface Apr 1, 2021
@PulkitGarg67
Copy link
Contributor Author

Thanks for the information. I have updated the code accordingly.

@Stypox Stypox requested a review from Redirion April 1, 2021 16:53
@Stypox
Copy link
Member

Stypox commented Apr 1, 2021

@Redirion I've assigned this to you, feel free to merge if you think it is ready. Code looks fine to me, but I did not test.

@Redirion
Copy link
Member

Redirion commented Apr 1, 2021

tested, works. @PulkitGarg67 can you squash your two commits into one?

git reset --soft HEAD~2
git add .
git commit -m "rename Playlist Name from playlist interface"
git push -fu origin issue5570

@Stypox
Copy link
Member

Stypox commented Apr 1, 2021

@Redirion you can squash and merge via GitHub

@XiangRongLin XiangRongLin added the feature request Issue is related to a feature in the app label Apr 1, 2021
@Redirion Redirion merged commit e1a6b69 into TeamNewPipe:dev Apr 1, 2021
This was referenced Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request Issue is related to a feature in the app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More logic renaming of playlists

4 participants