Skip to content

Add functionality to rename Playlist Name from playlist interface #5982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Add functionality to rename Playlist Name from playlist interface #5982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ef0d3e
Adding functionality to rename Playlist Name from playlist interface …
PulkitGarg67 Apr 1, 2021
45a1aa0
Code Optimization for rename function in playlist interface
PulkitGarg67 Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions app/src/main/java/org/schabi/newpipe/local/playlist/LocalPlaylistFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ public class LocalPlaylistFragment extends BaseLocalListFragment<List<PlaylistSt
// Save the list 10 seconds after the last change occurred
private static final long SAVE_DEBOUNCE_MILLIS = 10000;
private static final int MINIMUM_INITIAL_DRAG_VELOCITY = 12;

@State
protected Long playlistId;
@State
Expand Down Expand Up @@ -340,7 +339,8 @@ public void onError(final Throwable exception) {
}

@Override
public void onComplete() { }
public void onComplete() {
}
};
}

Expand All @@ -361,6 +361,8 @@ public boolean onOptionsItemSelected(final MenuItem item) {
.create()
.show();
}
} else if (item.getItemId() == R.id.menu_item_rename_playlist) {
createRenameDialog();
} else {
return super.onOptionsItemSelected(item);
}
Expand Down Expand Up @@ -420,7 +422,7 @@ public void removeWatchedStreams(final boolean removePartiallyWatched) {
playlistItem.getStreamId());

final boolean hasState = streamStatesIter.next() != null;
if (indexInHistory < 0 || hasState) {
if (indexInHistory < 0 || hasState) {
notWatchedItems.add(playlistItem);
} else if (!thumbnailVideoRemoved
&& playlistManager.getPlaylistThumbnail(playlistId)
Expand Down Expand Up @@ -722,7 +724,8 @@ public boolean isItemViewSwipeEnabled() {

@Override
public void onSwiped(@NonNull final RecyclerView.ViewHolder viewHolder,
final int swipeDir) { }
final int swipeDir) {
}
};
}

Expand Down Expand Up @@ -755,7 +758,7 @@ protected void showStreamItemDialog(final PlaylistStreamEntry item) {
StreamDialogEntry.append_playlist,
StreamDialogEntry.share
));
} else {
} else {
entries.addAll(Arrays.asList(
StreamDialogEntry.start_here_on_background,
StreamDialogEntry.start_here_on_popup,
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/res/menu/menu_local_playlist.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
<menu xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto">

<item
android:id="@+id/menu_item_rename_playlist"
android:title="@string/rename_playlist"
app:showAsAction="never" />
<item
android:id="@+id/menu_item_remove_watched"
android:title="@string/remove_watched"
Expand Down