Skip to content

Disable media tunneling on Hi3798MV200 #5969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

Disable media tunneling on Hi3798MV200 #5969

merged 1 commit into from
Mar 31, 2021

Conversation

@Redirion
Copy link
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Disabled media tunneling on affected devices.
In this PR: Formuler Z8 Pro, Z8, CC, Z Alpha, Z+ Neo

Fixes the following issue(s)

APK testing

This workaround was already tested, now it was just implemented in a more meaningful way.
APK can be found by going to the "Checks" tab below the title and then on "artifacts" on the right.

Due diligence

@Redirion Redirion requested a review from Stypox March 31, 2021 13:50
@Redirion Redirion force-pushed the tnnlwrkarnd branch 3 times, most recently from d5625b0 to d17c11c Compare March 31, 2021 14:12
Stypox
Stypox requested changes Mar 31, 2021
View reviewed changes
@Redirion Redirion closed this Mar 31, 2021
@Redirion Redirion reopened this Mar 31, 2021
@Redirion Redirion requested a review from Stypox March 31, 2021 14:43
Stypox
Stypox approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd wait for @TobiGr to merge since you started the discussion with him ;-)

@TobiGr TobiGr merged commit 66c24af into TeamNewPipe:dev Mar 31, 2021
@Redirion Redirion deleted the tnnlwrkarnd branch March 31, 2021 17:07
@AudricV AudricV added bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software player Issues related to any player (main, popup and background) labels Apr 1, 2021
@davidebeatrici davidebeatrici mentioned this pull request Apr 8, 2021
Merged
5 tasks
This was referenced Apr 11, 2021
Closed
Merged
tossj pushed a commit to tossj/NewPipe-legacy that referenced this pull request Apr 23, 2021
@TobiGr @tossj
Merge pull request TeamNewPipe/NewPipe#5969 from Redirion/tnnlwrkarnd
df20345 
Disable media tunneling on Hi3798MV200
@TobiGr TobiGr mentioned this pull request May 23, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiGr TobiGr TobiGr approved these changes

@Stypox Stypox Stypox approved these changes

Assignees

No one assigned

Labels

bug Issue is related to a bug device/software specific Issues that only happen on some devices or with some specific hardware/software player Issues related to any player (main, popup and background)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tunneling broken on HiSilicon Hi3798MV200 Black player screen on Formuler Z8 Android box

4 participants

@Redirion @TobiGr @Stypox @AudricV