Skip to content

Change Autoplay to Autoqueue to reduce ambiguity #4252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2020
Merged

Change Autoplay to Autoqueue to reduce ambiguity #4252

merged 2 commits into from
Sep 11, 2020

Conversation

opusforlife2
Copy link
Collaborator

What is it?

  • Bug fix (user facing)

Description of the changes in your PR

  • The toggle which appends related streams is called Autoplay. Now that there is an actual Autoplay setting, this can cause confusion for users.

Fixes the following issue(s)

  • Confusion

Agreement

@opusforlife2 opusforlife2 mentioned this pull request Sep 8, 2020
Closed
5 tasks
@opusforlife2 opusforlife2 requested a review from TobiGr September 8, 2020 10:48
TobiGr
TobiGr approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't have time to test the change and see it in the app.

@wb9688
Copy link
Contributor

wb9688 commented Sep 8, 2020

Is it possible to remove autoplay_title or do we depend on it elsewhere?

@opusforlife2
Copy link
Collaborator Author

Settings > The actual autoplay setting (off, wifi, always).

@wb9688
Copy link
Contributor

wb9688 commented Sep 8, 2020

Hmm… where is autoplay_by_calling_app_title used then?

@opusforlife2
Copy link
Collaborator Author

opusforlife2 commented Sep 8, 2020 •
edited
Loading

Wow. Nowhere. It's only present in XMLs.

Oh, I think this is for the setting that was present in 0.8.x and 0.9.x which autoplayed the video when coming from another app. It was removed at some point.

Stypox
Stypox approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected. Thank you ;-)

@Stypox Stypox merged commit 11d9a03 into TeamNewPipe:dev Sep 11, 2020
@opusforlife2 opusforlife2 deleted the autoplay_to_autoqueue2 branch September 11, 2020 20:13
This was referenced Sep 27, 2020
Closed
Merged
@TobiGr TobiGr added the localisation / translation Everything that has to do with translations or Weblate label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiGr TobiGr TobiGr approved these changes

@Stypox Stypox Stypox approved these changes

Assignees

No one assigned

Labels

localisation / translation Everything that has to do with translations or Weblate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@opusforlife2 @wb9688 @TobiGr @Stypox