Skip to content

Conversation

@opusforlife2
Copy link
Collaborator

What is it?

  • Bug fix (user facing)
  • Feature (user facing)
  • Code base improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • The toggle which appends related streams is called Autoplay. Now that there is an actual Autoplay setting, this can cause confusion for users.

Fixes the following issue(s)

  • Confusion

Agreement

This will remove ambiguity about the toggle, especially after an *actual* Autoplay setting was added as part of PR 2907.
@opusforlife2 opusforlife2 requested a review from Stypox September 7, 2020 19:48
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-queue next stream is quite long, some translations are even longer, e.g.

<string name="auto_queue_title">Apondre la vidèo seguenta dins la coa de lectura</string>
<string name="auto_queue_title">Colocar a seguinte emisión na cola automaticamente</string>

I think we should just use auto-queue or auto-enqueue

@opusforlife2
Copy link
Collaborator Author

opusforlife2 commented Sep 8, 2020

So should I add a new string instead? Something like:

<string name="auto_queue_toggle">Auto-queue</string>

@TobiGr
Copy link
Contributor

TobiGr commented Sep 8, 2020

I'd vote for that.

@opusforlife2
Copy link
Collaborator Author

#4252.

@opusforlife2 opusforlife2 deleted the autoplay_to_autoqueue branch September 8, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants