Skip to content

Conversation

Koitharu
Copy link
Contributor

@Koitharu Koitharu commented Apr 15, 2019

Implementation of displaying playback progress in lists

Screenshot_2019-04-15-22-25-20 Screenshot_2019-04-15-22-25-54

Code based on #2286 and is not ready for release yet

TobiGr
TobiGr previously approved these changes Jun 13, 2019
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TobiGr TobiGr mentioned this pull request Jun 13, 2019
1 task
@TobiGr
Copy link
Contributor

TobiGr commented Jun 17, 2019

@nv95 can you please resolve the conflicts? I don't speak Ukrainian:)

@Koitharu
Copy link
Contributor Author

@TobiGr ok

@Koitharu
Copy link
Contributor Author

Koitharu commented Jun 23, 2019

@TobiGr Sorry for delay

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. We are happy that you invested so much time into this feature. It is our fault that there were conflicts as we delayed the review and merge several times.

@TobiGr TobiGr merged commit 61472a9 into TeamNewPipe:dev Jun 23, 2019
@Stypox Stypox mentioned this pull request Jun 23, 2019
@Stypox
Copy link
Member

Stypox commented Jul 22, 2019

I'm trying to fix conflicts for #2368 and I don't understand what resumePlayback's value should be in playOn..Player and enqueueOn..Player functions. (especially when they are used in the long-press menu)
I see you are using it differently in showStreamDialog()s:

In the long-press menu I assume resumePlayback should be false for enqueue actions and true otherwise. I also assume in BaseListFragment and in VideoDetailFragment it is always true due to an oversight, since all other fragments don't do that and it makes more sense that enqueued items start playing from the beginning. Can you confirm @nv95?
If my second assumption is true, I will fix the oversight in #2368

EDIT: I edited my code in #2368 and the behaviour is the same with either values of resumePlayback (for enqueue actions): the enqueued item starts from the beginning.

Stypox added a commit to Stypox/NewPipe that referenced this pull request Jul 22, 2019
…alls.

`resumePlayback`'s value is `false` when the video is enqueued, `true` otherwise.
Also make the use of getContext() and getActivity() more consistant.
@Koitharu Koitharu mentioned this pull request Jul 30, 2019
1 task
@TobiGr TobiGr mentioned this pull request Jul 31, 2019
3 tasks
@TobiGr TobiGr mentioned this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants