Skip to content

Playback resume v2 #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Playback resume v2 #2286

wants to merge 2 commits into from

Conversation

Koitharu
Copy link
Contributor

@Koitharu Koitharu commented Apr 13, 2019 •
edited by TobiGr
Loading

Better implementation of #1968

@TobiGr
Copy link
Contributor

TobiGr commented Apr 14, 2019

Thanks!
I just skipped the code and it looks better indeed!
For some reason, scrolling is blocked by the new progress bar you introduced. This makes scrolling down impossible when the description is long. Looks like this:
playback-resume-scrolling.mp4.zip

I'll come back to this after 0.16.2 is released (so hopefully next week)

@Koitharu Koitharu mentioned this pull request Apr 15, 2019
Merged
1 task
TobiGr
TobiGr reviewed Apr 23, 2019
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skipped the code briefly and found one small thing. I'll come back for a more detailed review later as my time is limited atm.

TobiGr
TobiGr approved these changes Apr 28, 2019
View reviewed changes
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this after 0.16.2 is released.

@Stypox Stypox mentioned this pull request May 23, 2019
Closed
@TobiGr
Copy link
Contributor

TobiGr commented Jun 13, 2019

Closing in favour of #2288 as that PR is based on the commits from this PR

@TobiGr TobiGr closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TobiGr TobiGr TobiGr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Koitharu @TobiGr