Skip to content

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Jul 22, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

#12408 does not fix the underlying issue but tries to handle the symptoms. nextPage cannot be null when handleNextItems() is called, because at that point there is a page that was fetched.
#12408 made it so that is unlikely that error reports are generated. When there was an ExtractionException it is likely that there is no nextPage. The issue is that nextPage is reassigned before generating the error report.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@TobiGr TobiGr added the bug Issue is related to a bug label Jul 22, 2025
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Jul 22, 2025
@TobiGr TobiGr added this to v0.28.x Jul 22, 2025
@github-project-automation github-project-automation bot moved this to Todo in v0.28.x Jul 22, 2025
@TobiGr TobiGr moved this from Todo to In Progress in v0.28.x Jul 22, 2025
@ShareASmile ShareASmile added the search Anything related to the search function label Jul 23, 2025
@TobiGr TobiGr changed the base branch from dev to release-0.28.0 July 24, 2025 15:46
@koukibadr
Copy link
Contributor

koukibadr commented Jul 25, 2025

@TobiGr
#12408 does fix the pagination error crash, handleNextItems is called whenever there's a fetch for new data the fix was adding an assert to the page object when it's retrieved using nextPage = result.getNextPage(); so newPage could be null in this stage.
With this PR the retrieval of newPage is done after the assertion if so it won't be null, thisPR and #12408 are two possible fix solutions for the same bug.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should still report the error if nextPage == null, I pushed a commit to do that. Thanks!

@Stypox Stypox merged commit c1cef19 into TeamNewPipe:release-0.28.0 Jul 28, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in v0.28.x Jul 28, 2025
@TobiGr TobiGr deleted the nextPage-nullable branch July 28, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug search Anything related to the search function size/small PRs with less than 50 changed lines

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants