fix: handle nullable nextPage behavior when searching albums #12401

[koukibadr]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Handle display search results when nextPage is null on Albums mode

Before/After Screenshots/Screen Record

• Before:

before_fix.mov

• After:

after_fix.mov

Fixes the following issue(s)

• Fixes Crashed during Scrolling Search #12401

Due diligence

• I read the contribution guidelines.

[snaik20]

Thanks for this.

The NextPage field is used in few more places. Could you make sure those places are also handling the nullability correctly.

Also, the extractor function also needs to correctly set the @Nullable annotation to indicate that the returned value can be null. It would be nice if you could help with that as well (TeamNewPipe/NewPipeExtractor#1312). Thanks

[koukibadr]

@snaik20 yes sure I'll check these points and update the PR if needed then

[TobiGr]

Thank you for the PR!

However, I think the provided solution does not solve the underlying problem. I opened #12455 to fix it.

[TobiGr]

Hm, why is the nextPageInfo included in the error?
The nextPage might be null, but that does not mean that the extraction of the current page does not have any errors. We'd still want to get error reports in case the nextPage couldn't be extracted. The reassignment of nextPage needs to happen after the error report is generated.