Skip to content

Ugly fix for broken text colors in dark mode #12035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Ugly fix for broken text colors in dark mode #12035

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43e204a
Ugly fix for broken text colors in dark mode
Thompson3142 Feb 12, 2025
d74277f
Add comment for clarification
Thompson3142 Feb 12, 2025
f160c90
Added error prevention
Thompson3142 Feb 17, 2025
4130d02
Update app/src/main/java/org/schabi/newpipe/MainActivity.java
Stypox Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/src/main/java/org/schabi/newpipe/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import android.view.MenuItem;
import android.view.View;
import android.view.ViewGroup;
import android.webkit.WebView;
import android.widget.AdapterView;
import android.widget.ArrayAdapter;
import android.widget.FrameLayout;
Expand Down Expand Up @@ -140,6 +141,19 @@ protected void onCreate(final Bundle savedInstanceState) {
ThemeHelper.setDayNightMode(this);
ThemeHelper.setTheme(this, ServiceHelper.getSelectedServiceId(this));

// Fixes text color turning black in dark/black mode:
// https://github.com/TeamNewPipe/NewPipe/issues/12016
// For further reference see: https://issuetracker.google.com/issues/37124582
if (DeviceUtils.supportsWebView()) {
try {
new WebView(this);
} catch (final Throwable e) {
if (DEBUG) {
Log.e(TAG, "Failed to create WebView", e);
}
}
}

assureCorrectAppLanguage(this);
super.onCreate(savedInstanceState);

Expand Down