Ugly fix for broken text colors in dark mode #12035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for investigating! Maybe add a comment in the code |
AudricV
previously requested changes
Feb 16, 2025
AudricV
added
bug
Stypox
approved these changes
Feb 17, 2025
Stypox
reviewed
Feb 21, 2025
|
6 tasks
6 tasks
6 tasks
11 tasks
whistlingwoods
pushed a commit
to whistlingwoods/FoxPipe
that referenced
this pull request
Aug 25, 2025
* Ugly fix for broken text colors in dark mode * Add comment for clarification * Added error prevention * Update app/src/main/java/org/schabi/newpipe/MainActivity.java --------- Co-authored-by: Stypox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
An ugly fix for the issue that the text color is black in dark/black mode. WebView is unfortunately messing with the theme with no real way to prevent it (at least from my observation).
For some further reference: https://issuetracker.google.com/issues/37124582.
I am not entirely sure why this exactly helps but it seems like the first WebView instantiated sets the theme/context and following ones don't change it again?
If there is some other change that directly prevents this bug from occurring it should definitely be preferred.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence