Skip to content

Removed blacklist header from canonical calc #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed blacklist header from canonical calc #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions evaporate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,9 +1769,14 @@

addHeader('Host', awsRequest.awsHost);

if (this.request.contentType) {
addHeader('Content-Type', this.request.contentType || '');
}
/**
* Removed, reference `getHeaderBlacklist()` in https://github.com/aws/aws-sdk-php/blob/master/src/Signature/SignatureV4.php
* "The following headers are not signed because signing these header would potentially cause a signature
* mismatch when sending a request through a proxy or if modified at the HTTP client level."
*/
// if (this.request.contentType) {
// addHeader('Content-Type', this.request.contentType || '');
// }

var amzHeaders = this.request.x_amz_headers || {};
for (var key in amzHeaders) {
Expand Down