Removed blacklist header from canonical calc #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing the aws-sdk-php repo, removed the "Content-Type" header from being signed due to its existence on the header blacklist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In building a backend system to recreate and verify client request before signing them, I noticed the AWS SDK for PHP have blacklist of headers for those it will not sign.
As such, I have removed the
content-lengthheader fromAwsSignatureV4.prototype.canonicalHeadersfunction to align with AWS's signature process.AWS-SDK reference: https://github.com/aws/aws-sdk-php/blob/6ef06165ef815358d3e60872b4c9f6c10deb3816/src/Signature/SignatureV4.php#L40-L74