ST6RI-896 getDirectedUsage broken on an ActionDefinition or Constraint Definition #712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug which caused the method
Definition::getDirectedUsageto always return the empty list forActionDefinitionsandConstraintDefinitionseven if they did, in fact, havedirectedFeaturesthat wereUsages.Cause
The method
getDirectedUsagewas implemented by aDefaultDerivedPropertySettingDelegate, returning aDerivedEObjectEListsubsettingdirectedFeaturefor elements that areUsages. However, the propertydirectedFeatureis redefined asparameterforBehaviors, andActionDefinitionandConstraintDefinitionare kinds ofBehavior. Because of this, the dynamic get fordirectedFeatureinDerivedEObjectEListwas not returning anything, becausedirectedFeaturewas no longer a feature of theEClass.Fix
Added an explicit
Definition_directedUsage_SettingDelegatethat extendsDefaultPropertySettingDelegateand overrides the methodbasicGetto check if theowneris an instance ofActionDefinitionorConstraintDefinition. If so, then aDerivedEObjectEListis returned that derives fromparameterinstead ofdirectedFeature. Otherwise,DefaultDerivedPropertySettingDelegate::basicGetis used.