Skip to content

Refactor section assignment logic in SwanLabKey #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

Refactor section assignment logic in SwanLabKey #1172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions swanlab/data/run/key.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,14 +161,17 @@ def create_column(
"""
assert self.column_info is None, "Cannot create column info after creating it"
result = data.parse()

# 如果section_type不为public,则section_name为None
if section_type != "PUBLIC":
# SYSTEM PINNED HIDDEN 三个类型的 section 不应该传递名称
# PUBLIC 可选是否传递名称，如果 key 包含斜杠，则使用斜杠前的部分作为section的名称
# CUSTOM 时如果 key 包含斜杠，则使用斜杠前的部分作为section的名称，并且将 section_type 设置为 PUBLIC
if section_type in ["PUBLIC", "CUSTOM"]:
split_key = key.split("/")
if len(split_key) > 1 and split_key[0]:
# 如果key包含斜杠，则使用斜杠前的部分作为section的名称
result.section = split_key[0]
section_type: SectionType = "PUBLIC"
else:
result.section = None
# 如果斜杠，则使用斜杠前的部分作为section的名称
elif "/" in key and key[0] != "/":
result.section = key.split("/")[0]

column_info = ColumnInfo(
key=key,
kid=str(num),
Expand Down
Loading