Refactor section assignment logic in SwanLabKey #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the logic for assigning section names and types based on key and section_type. Now, PUBLIC and CUSTOM types use the prefix before a slash in the key as the section name, and CUSTOM type is treated as PUBLIC. SYSTEM, PINNED, and HIDDEN types do not assign a section name.
Zeyi-Lin
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the logic for assigning section names and types based on key and section_type. Now, PUBLIC and CUSTOM types use the prefix before a slash in the key as the section name, and CUSTOM type is treated as PUBLIC. SYSTEM, PINNED, and HIDDEN types do not assign a section name.