Skip to content

Allow configuring kubectl --request-timeout via env #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow configuring kubectl --request-timeout via env #894

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
559b163
Allow configuring kubectl --request-timeout via env
ekantola Jun 16, 2022
b81c431
Handle garbage KUBECTL_DEFAULT_REQUEST_TIMEOUT in a saner way
ekantola Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/krane/kubectl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ class Kubectl
empty: /\A\z/,
context_deadline: /context deadline exceeded/,
}
DEFAULT_TIMEOUT = 15
ENV_DEFAULT_TIMEOUT = ENV["KUBECTL_DEFAULT_REQUEST_TIMEOUT"]
DEFAULT_TIMEOUT = (ENV_DEFAULT_TIMEOUT if Integer(ENV_DEFAULT_TIMEOUT) rescue 15).to_i
MAX_RETRY_DELAY = 16
SERVER_DRY_RUN_MIN_VERSION = "1.13"

Expand Down