Allow configuring kubectl --request-timeout via env #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, ``` KUBECTL_DEFAULT_REQUEST_TIMEOUT=30 krane deploy ... ```
ekantola
requested review from
d1egoaz and
peiranliushop
and removed request for
a team
ghost
added
the
peiranliushop
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
What are you trying to accomplish with this PR?
Configurable timeout for deploys not to fail in a setup where the currently unconfigurable 15 seconds is not always enough
How is this accomplished?
Add support for configuring this through an environment variable, with the suggeste name
KUBECTL_DEFAULT_REQUEST_TIMEOUTWhat could go wrong?
Hmm, not much? Maybe env var naming conflicts in some fringe cases, but doesn't seem very likely.