-
Notifications
You must be signed in to change notification settings - Fork 17
Bug Fix: Setting the WEBSOCKET_URL var prod and dev #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dan-tw
merged 10 commits into
ScalablePixelStreaming:main
from
david-macpherson:BF_Prod_Dev_WEBSOCKET_URL
Feb 26, 2024
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7c042f1
Bug fix building for prod to exclude the WEBSOCKET_URL var stored in …
david-macpherson ede1e31
Updated the gitignore to remove ignore the .env file
david-macpherson dab568a
Added to check if the WEBSOCKET_URL is not undefined
david-macpherson e009a8f
Changed the WEBSOCKET_URL check to a blnk string instead of undefined
david-macpherson efdbbb8
Merge branch 'main' into BF_Prod_Dev_WEBSOCKET_URL
dan-tw 6d7c95c
Update webpack.dev.js
dan-tw ad85774
Merge remote-tracking branch 'refs/remotes/upstream/main' into BF_Pro…
david-macpherson 34e6558
Set the WEBSOCKET_URL to undefined if building for dev by default
david-macpherson 2c3e9be
Checks if the WEBSOCKET_URL variable has been set
david-macpherson bb31116
Merge branch 'BF_Prod_Dev_WEBSOCKET_URL' of github.com:david-macphers…
david-macpherson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,4 +3,4 @@ node_modules/ | |
| types/ | ||
| .vscode | ||
| !.env.example | ||
| .env | ||
| *.env | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,14 @@ | ||
| const { merge } = require('webpack-merge'); | ||
| const common = require('./webpack.common.js'); | ||
| const path = require('path'); | ||
| const webpack = require('webpack'); | ||
|
|
||
| module.exports = merge(common, { | ||
| mode: 'development', | ||
| devtool: 'source-map', | ||
| plugins: [ | ||
| new webpack.DefinePlugin({ | ||
| WEBSOCKET_URL: JSON.stringify((process.env.WEBSOCKET_URL !== undefined) ? process.env.WEBSOCKET_URL : '') | ||
| }), | ||
| ] | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,20 @@ | ||
| const { merge } = require('webpack-merge'); | ||
| const common = require('./webpack.common.js'); | ||
| const webpack = require('webpack'); | ||
|
|
||
| module.exports = merge(common, { | ||
| mode: 'production', | ||
| optimization: { | ||
| usedExports: true, | ||
| minimize: true | ||
| }, | ||
| stats: 'errors-only', | ||
| performance: { | ||
| hints: false | ||
| } | ||
| mode: 'production', | ||
| optimization: { | ||
| usedExports: true, | ||
| minimize: true | ||
| }, | ||
| stats: 'errors-only', | ||
| performance: { | ||
| hints: false | ||
| }, | ||
| plugins: [ | ||
| new webpack.DefinePlugin({ | ||
| WEBSOCKET_URL: undefined | ||
| }), | ||
| ] | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.