-
Notifications
You must be signed in to change notification settings - Fork 17
Bug Fix: Setting the WEBSOCKET_URL var prod and dev #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dan-tw
merged 10 commits into
ScalablePixelStreaming:main
from
david-macpherson:BF_Prod_Dev_WEBSOCKET_URL
Feb 26, 2024
Merged
Bug Fix: Setting the WEBSOCKET_URL var prod and dev #44
dan-tw
merged 10 commits into
ScalablePixelStreaming:main
from
david-macpherson:BF_Prod_Dev_WEBSOCKET_URL
Feb 26, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehb
reviewed
Feb 23, 2024
dan-tw
requested changes
Feb 26, 2024
…d_Dev_WEBSOCKET_URL
…on/Frontend into BF_Prod_Dev_WEBSOCKET_URL
lukehb
approved these changes
Feb 26, 2024
Collaborator
lukehb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dan-tw
approved these changes
Feb 26, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
If building for Prod the
WEBSOCKET_URLsupplied by the.envwill be still be bundled into the generated filesThe value of the
WEBSOCKET_URLshould only be bundled if built for devSolution
Move the logic for setting the
WEBSOCKET_URLfrom the .env file to the webpack dev configurationSet the
WEBSOCKET_URLto undefined when building for prodDocumentation
Test Plan and Compatibility
Built for dev while setting the
WEBSOCKET_URLvar in the.envfile and ensured the frontend was connecting to the supplied valueBuilt for dev without setting the value in the
.envfile and deployed to an sps install and ensured it was connecting to the generated websocket addressBuilt for prod while setting a value in the
.envvalue and ensured it was connecting to the websocket generated address