Skip to content

Conversation

@cianmSAP
Copy link
Contributor

@cianmSAP cianmSAP commented Oct 20, 2025

Internal ticket # 35418

Adds a new standalone SAP Systems extension

Creates 3 modules

  • sap-ux-sap-systems-ext
  • @sap-ux/sap-systems-ext-types
  • @sap-ux/sap-systems-ext-webapp

todo:
Update actions for publishing the extension

@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2025

🦋 Changeset detected

Latest commit: 530936e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@sap-ux/sap-systems-ext-webapp Patch
@sap-ux/sap-systems-ext-types Patch
sap-ux-sap-systems-ext Patch
@sap-ux/store Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/adp-tooling Patch
@sap-ux/app-config-writer Patch
@sap-ux/backend-proxy-middleware Patch
@sap-ux/create Patch
@sap-ux/deploy-config-generator-shared Patch
@sap-ux/deploy-config-sub-generator Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/fiori-app-sub-generator Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/generator-adp Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/repo-app-import-sub-generator Patch
@sap-ux/system-access Patch
@sap-ux/telemetry Patch
@sap-ux/ui-service-inquirer Patch
@sap-ux/ui-service-sub-generator Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/inquirer-common Patch
@sap-ux/ui5-library-reference-sub-generator Patch
@sap-ux/cap-config-writer Patch
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

devinea
devinea previously approved these changes Oct 28, 2025
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving.

Copy link
Contributor

@mikicvi-SAP mikicvi-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few very minor comments, just naming things.
Overall, the new extension looks very good, makes sense and is easy to follow.

  • Reviewed the sap-systems-ext-webapp only.

lfindlaysap
lfindlaysap previously approved these changes Oct 29, 2025
@cianmSAP cianmSAP requested a review from a team as a code owner October 29, 2025 21:40
Copy link
Contributor

@donal-tobin-sap donal-tobin-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be fine.
However because of the use of 4 spaces it is not possible to validate the yaml file.

https://stackoverflow.com/a/64999517/22148

@sonarqubecloud
Copy link

@donal-tobin-sap donal-tobin-sap self-requested a review October 31, 2025 12:48
@cianmSAP cianmSAP requested a review from devinea October 31, 2025 13:07
@donal-tobin-sap
Copy link
Contributor

Using admin rights as a devops task.

  • already reviewed, just conflict resolution.

@donal-tobin-sap donal-tobin-sap merged commit cc65eec into main Oct 31, 2025
16 checks passed
@donal-tobin-sap donal-tobin-sap deleted the feat/sap-systems-ext branch October 31, 2025 13:29
devinea added a commit that referenced this pull request Nov 3, 2025
* origin/main:
  chore: apply latest changesets
  3792/handle missing mta binary (#3793)
  chore: apply latest changesets
  feat(sap-systems): adds new SAP Systems extension (#3752)
  chore: apply latest changesets
  fix(backend-proxy-middleware): wrong 'path' and 'pathReplace' in case of appStudio full destination (#3787)
devinea added a commit that referenced this pull request Nov 3, 2025
…i_custom_into_fiori_tools_plugin

* origin/eslint9:
  chore: apply latest changesets
  3792/handle missing mta binary (#3793)
  chore: apply latest changesets
  feat(sap-systems): adds new SAP Systems extension (#3752)
  chore: apply latest changesets
  fix(backend-proxy-middleware): wrong 'path' and 'pathReplace' in case of appStudio full destination (#3787)
devinea added a commit that referenced this pull request Nov 3, 2025
* origin/main:
  chore: apply latest changesets
  Feat: warn the user when trying to store ABAP On Premise system with credentials (#3797)
  chore: apply latest changesets
  feat(preview-middleware): add log message for viewCache redirect (#3798)
  chore: apply latest changesets
  fix(odata-service-inquirer): 36119 default table message (#3777)
  chore: apply latest changesets
  3792/handle missing mta binary (#3793)
  chore: apply latest changesets
  feat(sap-systems): adds new SAP Systems extension (#3752)
  chore: apply latest changesets
  fix(backend-proxy-middleware): wrong 'path' and 'pathReplace' in case of appStudio full destination (#3787)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants