-
Notifications
You must be signed in to change notification settings - Fork 51
feat(sap-systems): adds new SAP Systems extension #3752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 530936e The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few very minor comments, just naming things.
Overall, the new extension looks very good, makes sense and is easy to follow.
- Reviewed the
sap-systems-ext-webapponly.
packages/sap-systems-ext-webapp/src/components/layout/main/systemTypes/SystemTypes.tsx
Outdated
Show resolved
Hide resolved
...ages/sap-systems-ext-webapp/test/unit/components/layout/main/systemInfo/CloudSystem.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to be fine.
However because of the use of 4 spaces it is not possible to validate the yaml file.
|
|
Using admin rights as a devops task.
|
* origin/main: chore: apply latest changesets 3792/handle missing mta binary (#3793) chore: apply latest changesets feat(sap-systems): adds new SAP Systems extension (#3752) chore: apply latest changesets fix(backend-proxy-middleware): wrong 'path' and 'pathReplace' in case of appStudio full destination (#3787)
…i_custom_into_fiori_tools_plugin * origin/eslint9: chore: apply latest changesets 3792/handle missing mta binary (#3793) chore: apply latest changesets feat(sap-systems): adds new SAP Systems extension (#3752) chore: apply latest changesets fix(backend-proxy-middleware): wrong 'path' and 'pathReplace' in case of appStudio full destination (#3787)
* origin/main: chore: apply latest changesets Feat: warn the user when trying to store ABAP On Premise system with credentials (#3797) chore: apply latest changesets feat(preview-middleware): add log message for viewCache redirect (#3798) chore: apply latest changesets fix(odata-service-inquirer): 36119 default table message (#3777) chore: apply latest changesets 3792/handle missing mta binary (#3793) chore: apply latest changesets feat(sap-systems): adds new SAP Systems extension (#3752) chore: apply latest changesets fix(backend-proxy-middleware): wrong 'path' and 'pathReplace' in case of appStudio full destination (#3787)



Internal ticket # 35418
Adds a new standalone SAP Systems extension
Creates 3 modules
sap-ux-sap-systems-ext@sap-ux/sap-systems-ext-types@sap-ux/sap-systems-ext-webapptodo:
Update actions for publishing the extension