Merge remote-tracking branch 'origin/eslint9' into eslint9_merge_fiori_custom_into_fiori_tools_plugin

* origin/eslint9:
  chore: apply latest changesets
  3792/handle missing mta binary (#3793)
  chore: apply latest changesets
  feat(sap-systems): adds new SAP Systems extension (#3752)
  chore: apply latest changesets
  fix(backend-proxy-middleware): wrong 'path' and 'pathReplace' in case of appStudio full destination (#3787)

Author: devinea

.github/workflows/pipeline.yml

@@ -26,7 +26,7 @@ jobs:
               uses: pnpm/[email protected]
               with:
                   run_install: |
-                    - args: [--frozen-lockfile]
+                      - args: [--frozen-lockfile]
             - name: Cache pnpm modules
               uses: actions/cache@v4
               env:
@@ -45,69 +45,78 @@ jobs:
             - name: Run build
               run: pnpm run build
               env:
-                NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
+                  NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
             - name: Run unit tests
               run: pnpm run test --tuiAutoExit
               env:
-                NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
+                  NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
             - name: Check for changeset files
               id: check_changeset_files
               uses: andstor/file-existence-action@v3
               with:
-                files: '.changeset/[!README]*.md'
-                fail: false
+                  files: '.changeset/[!README]*.md'
+                  fail: false
             - name: Validate changeset files if found
               if: steps.check_changeset_files.outputs.files_exists == 'true'
               run: pnpm changeset status
+            - name: Package SAP Systems VSCode extension
+              if: steps.check_changeset_files.outputs.files_exists == 'true' && matrix.os == 'ubuntu-latest' && matrix.node-version == '20.x'
+              run: |
+                  if grep -R "sap-ux-sap-systems-ext" .changeset/*.md >/dev/null 2>&1; then
+                    echo "sap-systems-ext referenced in changeset. Packaging extension..."
+                    pnpm --filter sap-ux-sap-systems-ext ide-ext:package
+                  else
+                    echo "sap-systems-ext not referenced in changeset. Skipping packaging."
+                  fi
             - name: Cache playwright browsers
               id: cache-playwright-browsers
               uses: actions/cache@v4
               with:
-                path: |
-                  ${{ runner.os == 'Windows' }}:
-                    C:\Users\runneradmin\AppData\Local\ms-playwright
-                  ${{ runner.os != 'Windows' }}:
-                    ~/.cache/ms-playwright
-                key: playwright-browsers-os-${{ matrix.os }}-node-version-${{ matrix.node-version }}
+                  path: |
+                      ${{ runner.os == 'Windows' }}:
+                        C:\Users\runneradmin\AppData\Local\ms-playwright
+                      ${{ runner.os != 'Windows' }}:
+                        ~/.cache/ms-playwright
+                  key: playwright-browsers-os-${{ matrix.os }}-node-version-${{ matrix.node-version }}
             - name: Install playwright chrome browsers
               if: steps.cache-playwright-browsers.outputs.cache-hit != 'true'
               run: npx playwright install chrome
             - name: Run integration tests
               run: pnpm run test:integration
               env:
-                NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
+                  NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
             - name: Upload playwright reports
               if: failure()
               uses: actions/upload-artifact@v4
               with:
-                name: playwright-reports-os-${{ matrix.os }}-node-version-${{ matrix.node-version }}
-                path: |
-                  packages/*/playwright-report
-                  !packages/*/node_modules
-                retention-days: 15
+                  name: playwright-reports-os-${{ matrix.os }}-node-version-${{ matrix.node-version }}
+                  path: |
+                      packages/*/playwright-report
+                      !packages/*/node_modules
+                  retention-days: 15
             - name: Run SonarCloud scan
               if: matrix.os == 'ubuntu-latest' && matrix.node-version == '20.x'
               shell: bash
               run: |
-                echo ${{ github.event.pull_request.number }} >> pr-event.txt
-                echo ${{ github.event.pull_request.head.ref }} >> pr-event.txt
-                echo ${{ github.event.pull_request.base.ref }} >> pr-event.txt
-        
+                  echo ${{ github.event.pull_request.number }} >> pr-event.txt
+                  echo ${{ github.event.pull_request.head.ref }} >> pr-event.txt
+                  echo ${{ github.event.pull_request.base.ref }} >> pr-event.txt
+
             - name: 'Prepare output artifact'
               if: matrix.os == 'ubuntu-latest' && matrix.node-version == '20.x'
               shell: bash
               run: touch output.tar && tar --exclude='./node_modules' --exclude='./dist' --exclude='./**/node_modules/**' --exclude='./**/dist/**' --exclude='./.git' --exclude 'output.tar' -czf output.tar .
-        
+
             - name: 'Upload sonar artifact'
               if: matrix.os == 'ubuntu-latest' && matrix.node-version == '20.x'
               uses: actions/upload-artifact@v4
               with:
-                name: sonar-artifact
-                path: |
-                  pr-event.txt
-                  output.tar
-                if-no-files-found: error
-                retention-days: 1
+                  name: sonar-artifact
+                  path: |
+                      pr-event.txt
+                      output.tar
+                  if-no-files-found: error
+                  retention-days: 1
     version:
         # Run version job only on pushes to the main branch. The job depends on completion of the build job.
         if: github.repository == 'SAP/open-ux-tools' && github.event_name == 'push' && github.ref == 'refs/heads/main'
@@ -124,8 +133,8 @@ jobs:
             - name: Setup pnpm
               uses: pnpm/[email protected]
               with:
-                run_install: |
-                  - args: [--frozen-lockfile]
+                  run_install: |
+                      - args: [--frozen-lockfile]
             - name: Cache pnpm modules
               uses: actions/cache@v4
               env:
@@ -170,8 +179,8 @@ jobs:
             - name: Setup pnpm
               uses: pnpm/[email protected]
               with:
-                run_install: |
-                  - args: [--frozen-lockfile]
+                  run_install: |
+                      - args: [--frozen-lockfile]
             - name: Cache pnpm modules
               uses: actions/cache@v4
               env:
@@ -190,7 +199,9 @@ jobs:
             - name: Replace placeholder with instrumentation key
               uses: jacobtomlinson/gha-find-replace@v3
               with:
-                  include: packages/fiori-mcp-server/src/telemetry/index.ts
+                  include: |
+                      packages/fiori-mcp-server/src/telemetry/index.ts
+                      packages/sap-systems-ext/src/utils/telemetryHelper.ts
                   find: 'ApplicationInsightsInstrumentationKeyPLACEH0LDER'
                   replace: ${{ secrets.INSTRUMENTATION_KEY }}
                   regex: false
@@ -205,20 +216,46 @@ jobs:
                   publish: pnpm ci:publish
               env:
                   GITHUB_TOKEN: ${{ secrets.ACCESS_PAT }}
-            - name: Prepare Slack notification message
+            - name: Create GitHub Release (sap-systems-ext)
+              if: env.SAP_SYSTEMS_EXT_CHANGED == 'true'
+              uses: softprops/action-gh-release@v1
+              with:
+                  tag_name: sap-systems-ext@${{ env.EXT_VERSION }}
+                  name: sap-systems-ext v${{ env.EXT_VERSION }}
+                  body: 'VSCode SAP Systems extension v${{ env.EXT_VERSION }} release.'
+                  draft: false
+                  prerelease: false
+                  generate_release_notes: true
+                  files: packages/sap-systems-ext/*.vsix
+                  fail_on_unmatched_files: true
+              env:
+                  GITHUB_TOKEN: ${{ secrets.ACCESS_PAT }}
+            - name: Prepare Slack notification message (published packages)
               if: steps.changesetPublish.outputs.published == 'true'
               run: |
-                # Random delimiter required to support multi-line environment variable value
-                EOF=$(dd if=/dev/urandom bs=15 count=1 status=none | base64)
-                echo "PUBLISHED_PACKAGES_MESSAGE<<$EOF" >> $GITHUB_ENV
-                # publishedPackages JSON format: '[{"name": "@sap-ux/axios-extension", "version": "1.0.2"}, {"name": "@sap-ux/fiori-freestyle-writer", "version": "0.15.12"}]'
-                echo "$(echo '${{ steps.changesetPublish.outputs.publishedPackages }}' | jq --raw-output 'map("*" + .name + "*" + " - " + "<https://www.npmjs.com/package/" + .name + "|" + .version + ">") | join("\\n")')" >> $GITHUB_ENV
-                echo "$EOF" >> $GITHUB_ENV
-            - name: Send Slack notification
+                  # Random delimiter required to support multi-line environment variable value
+                  EOF=$(dd if=/dev/urandom bs=15 count=1 status=none | base64)
+                  echo "PUBLISHED_PACKAGES_MESSAGE<<$EOF" >> $GITHUB_ENV
+                  # publishedPackages JSON format: '[{"name": "@sap-ux/axios-extension", "version": "1.0.2"}, {"name": "@sap-ux/fiori-freestyle-writer", "version": "0.15.12"}]'
+                  echo "$(echo '${{ steps.changesetPublish.outputs.publishedPackages }}' | jq --raw-output 'map("*" + .name + "*" + " - " + "<https://www.npmjs.com/package/" + .name + "|" + .version + ">") | join("\\n")')" >> $GITHUB_ENV
+                  echo "$EOF" >> $GITHUB_ENV
+            - name: Prepare Slack notification message (extension release only)
+              if: steps.changesetPublish.outputs.published != 'true' && env.SAP_SYSTEMS_EXT_CHANGED == 'true'
+              run: |
+                  echo "EXT_RELEASE_MESSAGE=:package: VSCode SAP Systems extension v${{ env.EXT_VERSION }} released (private package)." >> $GITHUB_ENV
+            - name: Send Slack notification (published packages)
               if: steps.changesetPublish.outputs.published == 'true'
               uses: slackapi/[email protected]
               with:
-                payload: |
-                  {"text": ":rocket: The following packages were published to npmjs.com:\n${{ env.PUBLISHED_PACKAGES_MESSAGE }}" }
+                  payload: |
+                      {"text": ":rocket: The following packages were published to npmjs.com:\n${{ env.PUBLISHED_PACKAGES_MESSAGE }}" }
+              env:
+                  SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
+            - name: Send Slack notification (extension release)
+              if: steps.changesetPublish.outputs.published != 'true' && env.SAP_SYSTEMS_EXT_CHANGED == 'true'
+              uses: slackapi/[email protected]
+              with:
+                  payload: |
+                      {"text": "${{ env.EXT_RELEASE_MESSAGE }}" }
               env:
-                SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
+                  SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

.vscode/launch.json

@@ -182,11 +182,7 @@
             "request": "launch",
             "name": "fiori-mcp-server: Launch inspector",
             "runtimeExecutable": "npx",
-            "runtimeArgs": [
-                "@modelcontextprotocol/inspector",
-                "node",
-                "dist/index.js"
-            ],
+            "runtimeArgs": ["@modelcontextprotocol/inspector", "node", "dist/index.js"],
             "console": "integratedTerminal",
             "skipFiles": ["<node_internals>/**"],
             "cwd": "${workspaceFolder}/packages/fiori-mcp-server"
@@ -510,14 +506,23 @@
             "request": "launch",
             "name": "repo-app-import-sub-generator: Launch Yeoman generators/app",
             "program": "${workspaceFolder}/packages/repo-app-import-sub-generator/node_modules/yo/lib/cli.js",
-            "args": [
-              "${workspaceFolder}/packages/repo-app-import-sub-generator/generators/app/index.js"
-            ],
-            "env": {
-            },
+            "args": ["${workspaceFolder}/packages/repo-app-import-sub-generator/generators/app/index.js"],
+            "env": {},
             "stopOnEntry": true,
             "console": "integratedTerminal",
             "internalConsoleOptions": "neverOpen"
+        },
+        {
+            "name": "SAP Systems: Launch Extension",
+            "type": "extensionHost",
+            "request": "launch",
+            "runtimeExecutable": "${execPath}",
+            "args": ["--log=debug", "--extensionDevelopmentPath=${workspaceFolder}/packages/sap-systems-ext/"],
+            "outFiles": ["${workspaceFolder}/packages/sap-systems-ext/dist/**/*.js"],
+            "env": {
+                "SS_WEBAPP_PATH": "../sap-systems-ext-webapp/dist",
+                "SAP_UX_FIORI_TOOLS_DISABLE_TELEMETRY": "true"
+            }
         }
     ]
 }

examples/simple-generator/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @sap-ux/generator-simple-fe
 
+## 1.1.105
+
+### Patch Changes
+
+-   @sap-ux/system-access@0.6.27
+-   @sap-ux/fiori-elements-writer@2.7.34
+-   @sap-ux/fiori-freestyle-writer@2.4.59
+
 ## 1.1.104
 
 ### Patch Changes

examples/simple-generator/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@sap-ux/generator-simple-fe",
-    "version": "1.1.104",
+    "version": "1.1.105",
     "description": "Simple example of a yeoman generator for Fiori elements.",
     "license": "Apache-2.0",
     "private": true,

packages/abap-deploy-config-inquirer/CHANGELOG.md

@@ -1,5 +1,16 @@
 # @sap-ux/abap-deploy-config-inquirer
 
+## 1.6.42
+
+### Patch Changes
+
+-   Updated dependencies [cc65eec]
+    -   @sap-ux/store@1.3.2
+    -   @sap-ux/fiori-generator-shared@0.13.31
+    -   @sap-ux/system-access@0.6.27
+    -   @sap-ux/ui5-config@0.29.8
+    -   @sap-ux/inquirer-common@0.8.10
+
 ## 1.6.41
 
 ### Patch Changes

packages/abap-deploy-config-inquirer/package.json

@@ -6,7 +6,7 @@
         "url": "https://github.com/SAP/open-ux-tools.git",
         "directory": "packages/abap-deploy-config-inquirer"
     },
-    "version": "1.6.41",
+    "version": "1.6.42",
     "license": "Apache-2.0",
     "main": "dist/index.js",
     "scripts": {

packages/abap-deploy-config-sub-generator/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @sap-ux/abap-deploy-config-sub-generator
 
+## 0.1.91
+
+### Patch Changes
+
+-   @sap-ux/abap-deploy-config-inquirer@1.6.42
+-   @sap-ux/deploy-config-generator-shared@0.1.50
+-   @sap-ux/fiori-generator-shared@0.13.31
+-   @sap-ux/ui5-config@0.29.8
+-   @sap-ux/abap-deploy-config-writer@0.2.32
+
 ## 0.1.90
 
 ### Patch Changes

packages/abap-deploy-config-sub-generator/package.json

@@ -6,7 +6,7 @@
         "url": "https://github.com/SAP/open-ux-tools.git",
         "directory": "packages/abap-deploy-config-sub-generator"
     },
-    "version": "0.1.90",
+    "version": "0.1.91",
     "license": "Apache-2.0",
     "main": "generators/app/index.js",
     "scripts": {

packages/abap-deploy-config-writer/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @sap-ux/abap-deploy-config-writer
 
+## 0.2.32
+
+### Patch Changes
+
+-   @sap-ux/system-access@0.6.27
+-   @sap-ux/ui5-config@0.29.8
+
 ## 0.2.31
 
 ### Patch Changes

packages/abap-deploy-config-writer/package.json

@@ -6,7 +6,7 @@
         "url": "https://github.com/SAP/open-ux-tools.git",
         "directory": "packages/abap-deploy-config-writer"
     },
-    "version": "0.2.31",
+    "version": "0.2.32",
     "license": "Apache-2.0",
     "main": "dist/index.js",
     "scripts": {