feat: OpenAPI Generator to support float[] over List<BigDecimal>

datamodel/openapi/openapi-generator/src/main/java/com/sap/cloud/sdk/datamodel/openapi/generator/GenerationConfigurationConverter.java

@@ -1,6 +1,7 @@
 package com.sap.cloud.sdk.datamodel.openapi.generator;
 
 import static com.sap.cloud.sdk.datamodel.openapi.generator.GeneratorCustomProperties.FIX_REDUNDANT_IS_BOOLEAN_PREFIX;
+import static com.sap.cloud.sdk.datamodel.openapi.generator.GeneratorCustomProperties.USE_FLOAT_ARRAYS;
 import static com.sap.cloud.sdk.datamodel.openapi.generator.GeneratorCustomProperties.USE_ONE_OF_CREATORS;
 
 import java.nio.file.Path;
@@ -20,6 +21,7 @@
 import org.openapitools.codegen.CodegenConstants;
 import org.openapitools.codegen.CodegenModel;
 import org.openapitools.codegen.CodegenOperation;
+import org.openapitools.codegen.CodegenProperty;
 import org.openapitools.codegen.config.GlobalSettings;
 import org.openapitools.codegen.languages.JavaClientCodegen;
 import org.openapitools.codegen.model.ModelMap;
@@ -84,6 +86,31 @@ private static JavaClientCodegen createCodegenConfig( @Nonnull final GenerationC
         final var doubleIs = Pattern.compile("^isIs[A-Z]").asPredicate();
         return new JavaClientCodegen()
         {
+            @SuppressWarnings( { "rawtypes", "RedundantSuppression" } )
+            @Override
+            protected void updatePropertyForArray(
+                @Nonnull final CodegenProperty property,
+                @Nonnull final CodegenProperty innerProperty )
+            {
+                super.updatePropertyForArray(property, innerProperty);
+
+                if( USE_FLOAT_ARRAYS.isEnabled(config) && innerProperty.isNumber && property.isArray ) {
+                    property.datatypeWithEnum = "float[]";
+                    property.vendorExtensions.put("isPrimitiveArray", true);
+                }
+            }
+
+            @SuppressWarnings( { "rawtypes", "RedundantSuppression" } )
+            @Override
+            @Nullable
+            public String toDefaultValue( @Nonnull final CodegenProperty cp, @Nonnull final Schema schema )
+            {
+                if( USE_FLOAT_ARRAYS.isEnabled(config) && "float[]".equals(cp.datatypeWithEnum) ) {
+                    return null;
+                }
+                return super.toDefaultValue(cp, schema);
+            }
+
             @Override
             @Nullable
             public String toBooleanGetter( @Nullable final String name )

datamodel/openapi/openapi-generator/src/main/java/com/sap/cloud/sdk/datamodel/openapi/generator/GeneratorCustomProperties.java

@@ -20,7 +20,12 @@ enum GeneratorCustomProperties
     /**
      * Fix isIsBoolean() to isBoolean() for fields specified as `"isBoolean":{"type":"boolean"}`.
      */
-    FIX_REDUNDANT_IS_BOOLEAN_PREFIX("fixRedundantIsBooleanPrefix", "false");
+    FIX_REDUNDANT_IS_BOOLEAN_PREFIX("fixRedundantIsBooleanPrefix", "false"),
+
+    /**
+     * Use float arrays instead of big-decimal lists.
+     */
+    USE_FLOAT_ARRAYS("useFloatArrays", "false");
 
     private final String key;
     private final String defaultValue;

datamodel/openapi/openapi-generator/src/main/resources/openapi-generator/mustache-templates/pojo.mustache

@@ -121,6 +121,7 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
     return this;
   }
   {{#isArray}}
+  {{^vendorExtensions.isPrimitiveArray}}
   /**
    * Add one {{nameInCamelCase}} instance to this {@link {{classname}}}.
    * @param {{name}}Item The {{nameInCamelCase}} that should be added
@@ -146,6 +147,7 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
     return this;
     {{/vendorExtensions.x-is-jackson-optional-nullable}}
   }
+  {{/vendorExtensions.isPrimitiveArray}}
   {{/isArray}}
   {{#isMap}}
 
@@ -328,7 +330,7 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
     }
     final {{classname}} {{classVarName}} = ({{classname}}) o;
     return Objects.equals(this.cloudSdkCustomFields, {{classVarName}}.cloudSdkCustomFields){{#hasVars}} &&
-        {{#vars}}{{#vendorExtensions.x-is-jackson-optional-nullable}}equalsNullable(this.{{name}}, {{classVarName}}.{{name}}){{/vendorExtensions.x-is-jackson-optional-nullable}}{{^vendorExtensions.x-is-jackson-optional-nullable}}{{#isByteArray}}Arrays{{/isByteArray}}{{^isByteArray}}Objects{{/isByteArray}}.equals(this.{{name}}, {{classVarName}}.{{name}}){{/vendorExtensions.x-is-jackson-optional-nullable}}{{^-last}} &&
+        {{#vars}}{{#vendorExtensions.x-is-jackson-optional-nullable}}equalsNullable(this.{{name}}, {{classVarName}}.{{name}}){{/vendorExtensions.x-is-jackson-optional-nullable}}{{^vendorExtensions.x-is-jackson-optional-nullable}}{{#isByteArray}}Arrays{{/isByteArray}}{{^isByteArray}}{{^vendorExtensions.isPrimitiveArray}}Objects{{/vendorExtensions.isPrimitiveArray}}{{#vendorExtensions.isPrimitiveArray}}Arrays{{/vendorExtensions.isPrimitiveArray}}{{/isByteArray}}.equals(this.{{name}}, {{classVarName}}.{{name}}){{/vendorExtensions.x-is-jackson-optional-nullable}}{{^-last}} &&
         {{/-last}}{{/vars}}{{/hasVars}}{{#parent}} &&
         super.equals(o){{/parent}};
   {{/useReflectionEqualsHashCode}}
@@ -344,7 +346,7 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
     return HashCodeBuilder.reflectionHashCode(this);
   {{/useReflectionEqualsHashCode}}
   {{^useReflectionEqualsHashCode}}
-    return Objects.hash({{#vars}}{{#vendorExtensions.x-is-jackson-optional-nullable}}hashCodeNullable({{name}}){{/vendorExtensions.x-is-jackson-optional-nullable}}{{^vendorExtensions.x-is-jackson-optional-nullable}}{{^isByteArray}}{{name}}{{/isByteArray}}{{#isByteArray}}Arrays.hashCode({{name}}){{/isByteArray}}{{/vendorExtensions.x-is-jackson-optional-nullable}}{{^-last}}, {{/-last}}{{/vars}}{{#hasVars}}, {{/hasVars}}cloudSdkCustomFields{{#parent}}, super.hashCode(){{/parent}});
+    return Objects.hash({{#vars}}{{#vendorExtensions.x-is-jackson-optional-nullable}}hashCodeNullable({{name}}){{/vendorExtensions.x-is-jackson-optional-nullable}}{{^vendorExtensions.x-is-jackson-optional-nullable}}{{^isByteArray}}{{^vendorExtensions.isPrimitiveArray}}{{name}}{{/vendorExtensions.isPrimitiveArray}}{{#vendorExtensions.isPrimitiveArray}}Arrays.hashCode({{name}}){{/vendorExtensions.isPrimitiveArray}}{{/isByteArray}}{{#isByteArray}}Arrays.hashCode({{name}}){{/isByteArray}}{{/vendorExtensions.x-is-jackson-optional-nullable}}{{^-last}}, {{/-last}}{{/vars}}{{#hasVars}}, {{/hasVars}}cloudSdkCustomFields{{#parent}}, super.hashCode(){{/parent}});
   {{/useReflectionEqualsHashCode}}
   }{{#vendorExtensions.x-jackson-optional-nullable-helpers}}
 

datamodel/openapi/openapi-generator/src/test/java/com/sap/cloud/sdk/datamodel/openapi/generator/DataModelGeneratorIntegrationTest.java

@@ -34,7 +34,7 @@ private enum TestCase
             true,
             true,
             6,
-            Map.of("aiSdkConstructor", "true", "fixRedundantIsBooleanPrefix", "true")),
+            Map.of("aiSdkConstructor", "true", "fixRedundantIsBooleanPrefix", "true", "useFloatArrays", "true")),
         API_CLASS_VENDOR_EXTENSION_YAML(
             "api-class-vendor-extension-yaml",
             "sodastore.yaml",

datamodel/openapi/openapi-generator/src/test/resources/DataModelGeneratorIntegrationTest/api-class-for-ai-sdk/input/sodastore.json

@@ -178,9 +178,15 @@
           "price": {
             "type": "number",
             "format": "float"
+          },
+          "embedding":{
+            "type": "array",
+            "items": {
+              "type": "number"
+            }
           }
         },
-        "required": ["name", "brand", "flavor", "price"]
+        "required": ["name", "brand", "flavor", "price", "embedding"]
       },
       "NewSoda": {
         "type": "object",

datamodel/openapi/openapi-generator/src/test/resources/DataModelGeneratorIntegrationTest/api-class-for-ai-sdk/output/com/sap/cloud/sdk/services/builder/model/Soda.java

@@ -26,6 +26,10 @@
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonTypeName;
 import com.fasterxml.jackson.annotation.JsonValue;
+import java.math.BigDecimal;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
 import com.fasterxml.jackson.annotation.JsonAnySetter;
 import com.fasterxml.jackson.annotation.JsonAnyGetter;
 import com.fasterxml.jackson.annotation.JsonIgnore;
@@ -59,6 +63,9 @@ public class Soda
   @JsonProperty("price")
   private Float price;
 
+  @JsonProperty("embedding")
+  private float[] embedding;
+
   @JsonAnySetter
   @JsonAnyGetter
   private final Map<String, Object> cloudSdkCustomFields = new LinkedHashMap<>();
@@ -237,6 +244,35 @@ public void setPrice( @Nonnull final Float price) {
     this.price = price;
   }
 
+  /**
+   * Set the embedding of this {@link Soda} instance and return the same instance.
+   *
+   * @param embedding  The embedding of this {@link Soda}
+   * @return The same instance of this {@link Soda} class
+   */
+  @Nonnull public Soda embedding( @Nonnull final float[] embedding) {
+    this.embedding = embedding;
+    return this;
+  }
+
+  /**
+   * Get embedding
+   * @return embedding  The embedding of this {@link Soda} instance.
+   */
+  @Nonnull
+  public float[] getEmbedding() {
+    return embedding;
+  }
+
+  /**
+   * Set the embedding of this {@link Soda} instance.
+   *
+   * @param embedding  The embedding of this {@link Soda}
+   */
+  public void setEmbedding( @Nonnull final float[] embedding) {
+    this.embedding = embedding;
+  }
+
   /**
    * Get the names of the unrecognizable properties of the {@link Soda}.
    * @return The set of properties names
@@ -279,6 +315,7 @@ public Map<String, Object> toMap()
     if( isAvailable != null ) declaredFields.put("isAvailable", isAvailable);
     if( flavor != null ) declaredFields.put("flavor", flavor);
     if( price != null ) declaredFields.put("price", price);
+    if( embedding != null ) declaredFields.put("embedding", embedding);
     return declaredFields;
   }
 
@@ -310,12 +347,13 @@ public boolean equals(@Nullable final java.lang.Object o) {
         Objects.equals(this.brand, soda.brand) &&
         Objects.equals(this.isAvailable, soda.isAvailable) &&
         Objects.equals(this.flavor, soda.flavor) &&
-        Objects.equals(this.price, soda.price);
+        Objects.equals(this.price, soda.price) &&
+        Arrays.equals(this.embedding, soda.embedding);
   }
 
   @Override
   public int hashCode() {
-    return Objects.hash(id, name, brand, isAvailable, flavor, price, cloudSdkCustomFields);
+    return Objects.hash(id, name, brand, isAvailable, flavor, price, Arrays.hashCode(embedding), cloudSdkCustomFields);
   }
 
   @Override
@@ -328,6 +366,7 @@ public int hashCode() {
     sb.append("    isAvailable: ").append(toIndentedString(isAvailable)).append("\n");
     sb.append("    flavor: ").append(toIndentedString(flavor)).append("\n");
     sb.append("    price: ").append(toIndentedString(price)).append("\n");
+    sb.append("    embedding: ").append(toIndentedString(embedding)).append("\n");
     cloudSdkCustomFields.forEach((k,v) -> sb.append("    ").append(k).append(": ").append(toIndentedString(v)).append("\n"));
     sb.append("}");
     return sb.toString();