feat: OpenAPI Generator to support float[] over List<BigDecimal>
#734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newtork
changed the title
float[] over List<BigDecimal>float[] over List<BigDecimal>
…elGeneratorIntegrationTest/openai-2024-10-21/output/com/sap/cloud/sdk/services/openai/api/DefaultApi.java
…d/sdk/datamodel/openapi/generator/DataModelGeneratorIntegrationTest.java
newtork
commented
Feb 26, 2025
Comment on lines
+63
to
+64
| @JsonProperty("embedding") | ||
| private float[] embedding; |
There was a problem hiding this comment.
For comparison, without feature toggle:
@JsonProperty("embedding")
private List<BigDecimal> embedding = new ArrayList<>();
8 tasks
rpanackal
reviewed
Feb 26, 2025
...tegrationTest/api-class-for-ai-sdk/output/com/sap/cloud/sdk/services/builder/model/Soda.java
Outdated
Show resolved
Hide resolved
…f-bigdecimal-list # Conflicts: # datamodel/openapi/openapi-generator/src/main/java/com/sap/cloud/sdk/datamodel/openapi/generator/GenerationConfigurationConverter.java # datamodel/openapi/openapi-generator/src/main/java/com/sap/cloud/sdk/datamodel/openapi/generator/GeneratorCustomProperties.java # datamodel/openapi/openapi-generator/src/test/java/com/sap/cloud/sdk/datamodel/openapi/generator/DataModelGeneratorIntegrationTest.java # datamodel/openapi/openapi-generator/src/test/resources/DataModelGeneratorIntegrationTest/api-class-for-ai-sdk/output/com/sap/cloud/sdk/services/builder/model/Soda.java
…l-list' into float-array-instead-of-bigdecimal-list
Co-authored-by: Roshin Rajan Panackal <[email protected]>
Co-authored-by: Alexander Dümont <[email protected]>
rpanackal
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://github.com/SAP/ai-sdk-java-backlog/issues/170
We want to have the option to have low-memory-footprint
float[]instead of verboseList<BigDecimal>in generated code.Unfortunately there is no convenience API or plugin property or CLI argument to serve this feature.
Feature scope:
arraywith item typenumber(notinteger!), then generatefloat[]Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated