Skip to content

Fix test-type-description-service.js flakiness #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Fix test-type-description-service.js flakiness #1155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions test/test-type-description-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,13 @@ const TypeDescriptionService = require('../lib/type_description_service.js');

describe('type description service test suite', function () {
this.timeout(60 * 1000);
let node;

beforeEach(function () {
return rclnodejs.init();
beforeEach(async function () {
await rclnodejs.init();
const nodeName = 'test_type_description_service';
node = rclnodejs.createNode(nodeName);
rclnodejs.spin(node);
Copy link

Copilot AI May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the test node created in beforeEach is properly shut down or cleaned up in afterEach to prevent potential resource leaks or interference between tests.

Copilot uses AI. Check for mistakes.

});

afterEach(function () {
Expand All @@ -35,9 +39,7 @@ describe('type description service test suite', function () {
this.skip();
return;
}
// Create a node and a publisher
const nodeName = 'test_type_description_service';
const node = rclnodejs.createNode(nodeName);
// Create a publisher
const topic = 'test_get_type_description_publisher';
const topicType = 'std_msgs/msg/String';
node.createPublisher(topicType, topic);
Expand Down Expand Up @@ -66,6 +68,5 @@ describe('type description service test suite', function () {
assert.notStrictEqual(response.type_sources.length, 0);
done();
});
rclnodejs.spin(node);
});
});
Loading