Fix test-type-description-service.js flakiness #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the flakiness in the test-type-description-service.js test suite by updating the asynchronous initialization pattern.
- Converts beforeEach to an async function, awaiting rclnodejs.init()
- Creates and spins a test node in beforeEach instead of within individual tests
| await rclnodejs.init(); | ||
| const nodeName = 'test_type_description_service'; | ||
| node = rclnodejs.createNode(nodeName); | ||
| rclnodejs.spin(node); |
There was a problem hiding this comment.
Ensure that the test node created in beforeEach is properly shut down or cleaned up in afterEach to prevent potential resource leaks or interference between tests.
Copilot uses AI. Check for mistakes.
minggangw
added a commit
that referenced
this pull request
Jun 6, 2025
This PR addresses the flakiness in the test-type-description-service.js test suite by updating the asynchronous initialization pattern. - Converts beforeEach to an async function, awaiting rclnodejs.init() - Creates and spins a test node in beforeEach instead of within individual tests Fix: #1154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the flakiness in the test-type-description-service.js test suite by updating the asynchronous initialization pattern.
Fix: #1154