-
Notifications
You must be signed in to change notification settings - Fork 194
XML parser for /etc/libvirt/qemu/*.xml files #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5b3bd2d
to
3f9a706
Compare
@psachin - please open a Jira request to add this spec to uploader.json at first, thanks. |
2a07442
to
74f80c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might also consider making the module name qemu_xml.py
.
|
||
@parser(Specs.etc_libvirt_qemu_xml) | ||
class EtcLibvirtQemuXML(XMLParser): | ||
"""This class parses xml files under ``/etc/libvirt/qemu/`` using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psachin what do you think about shortening this class name to QemuXML
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same opinion in mind, the long file and class name does not look so good(qemu_xml
reads nice) but they clearly indicates the file path the parser will parse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to express the whole file path in the class name and module name? This kind of name style is quite different from all the existing parsers. Unless the parser's logic depends on the specified file_path
, I think it would be better to user QemuXML or LibvirtQemuXml instead, IMHO, the Etc
is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class renamed to QemuXML
""" | ||
EtcLibvirtQemuXML file ``/etc/libvirt/qemu/*.xml`` | ||
-------------------------------------------------- | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a .rst
file to the docs directory for this parser to include it in the documentation, and confirm that the rendered documentation looks correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
</domain> | ||
|
||
Examples: | ||
>>> xml_numa.file_name = 'vm.xml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an assert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good catch. Thanks!!
|
||
@property | ||
def vm_name(self): | ||
if self.parse_dom(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you can just use self.data
here since the base class parse_content()
calls parse_dom()
and saves the results in self.data
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Signed-off-by: Sachin Patil <[email protected]>
Signed-off-by: Sachin Patil <[email protected]>
Signed-off-by: Sachin Patil <[email protected]>
Signed-off-by: Sachin Patil <[email protected]>
``parse_dom()``: Create a dict of immediate and second child under 'domain' Signed-off-by: Sachin Patil <[email protected]>
Signed-off-by: Sachin Patil <[email protected]>
Signed-off-by: Sachin Patil <[email protected]>
69dd995
to
f9fe027
Compare
Signed-off-by: Sachin Patil <[email protected]>
Signed-off-by: Sachin Patil <[email protected]>
* Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]>
|
||
def test_vm_xml(): | ||
xml = qemu_xml.QemuXML(context_wrap(XML_NUMA, path='/etc/libvirt/qemu/vm.xml')) | ||
xml.file_name = 'vm.xml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psachin .file_name
and .file_path
attributes are set by the parser based on the path=
attribute to context_wrap
. There's no need to set it here. Did you mean to use assert
instead? Same comment for the other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! My intention was to check assertion. (I need coffee ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: Sachin Patil <[email protected]>
* XML file parser for /etc/libvirt/qemu/*.xml Signed-off-by: Sachin Patil <[email protected]> * Added Docs Signed-off-by: Sachin Patil <[email protected]> * More tests against local VM's XML file Signed-off-by: Sachin Patil <[email protected]> * Obfuscate MAC address Signed-off-by: Sachin Patil <[email protected]> * Create a minimal dom dict ``parse_dom()``: Create a dict of immediate and second child under 'domain' Signed-off-by: Sachin Patil <[email protected]> * Test empty domain file. Signed-off-by: Sachin Patil <[email protected]> * Added (missed)documentation and changes as per review. Signed-off-by: Sachin Patil <[email protected]> * Renamed file and class. Signed-off-by: Sachin Patil <[email protected]> * Specs (re-)arranged as per alphabetical order Signed-off-by: Sachin Patil <[email protected]> * Fix missing `assert` Signed-off-by: Sachin Patil <[email protected]> (cherry picked from commit 023b4f8)
* Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]>
* spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json * change hostname to hostname -f * Add spec for subscription_manager_release_show (#155) * Specs for ovirt engine logs (#151) * Parser: RedHatInsights/insights-core#1336 * Plugin: RedHatInsights/insights-plugins#977 Signed-off-by: Sachin Patil <[email protected]> * Added specs for ls_lib_firmware (#153) * Added specs for ls_lib_firmware * Modified specs as per base class FileListing * Modified specs name * Apply filters and sign uploader[.v2].json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json * change hostname to hostname -f * Add spec for subscription_manager_release_show (#155) * Specs for ovirt engine logs (#151) * Parser: RedHatInsights/insights-core#1336 * Plugin: RedHatInsights/insights-plugins#977 Signed-off-by: Sachin Patil <[email protected]> * Added specs for ls_lib_firmware (#153) * Added specs for ls_lib_firmware * Modified specs as per base class FileListing * Modified specs name * Apply filters and sign uploader[.v2].json * Update signature for uploader json * Add Json signature check jenkins job * Fix typo in json check * Fix another typo in json sig check * force gpg check on deploy * Add some garbage to jenkins to make sure it fails * add notify * remove debug * debug * add header * remove debug * Add spec for command systool_b_scsi_v (#158) * Specs for collect /etc/sysconfig/libvirt-guests (#160) * Parser PR: RedHatInsights/insights-core#1392 Signed-off-by: Sachin Patil <[email protected]> * Added specs for neutron_conf (#161) * Puppetserver config spec (#162) * spec for puppetserver_config * delete wrong empty line * adding amq broker xml specs (#165) * Update and sign uploader.json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json * change hostname to hostname -f * Add spec for subscription_manager_release_show (#155) * Specs for ovirt engine logs (#151) * Parser: RedHatInsights/insights-core#1336 * Plugin: RedHatInsights/insights-plugins#977 Signed-off-by: Sachin Patil <[email protected]> * Added specs for ls_lib_firmware (#153) * Added specs for ls_lib_firmware * Modified specs as per base class FileListing * Modified specs name * Apply filters and sign uploader[.v2].json * Update signature for uploader json * Add Json signature check jenkins job * Fix typo in json check * Fix another typo in json sig check * force gpg check on deploy * Add some garbage to jenkins to make sure it fails * add notify * remove debug * debug * add header * remove debug * Add spec for command systool_b_scsi_v (#158) * Specs for collect /etc/sysconfig/libvirt-guests (#160) * Parser PR: RedHatInsights/insights-core#1392 Signed-off-by: Sachin Patil <[email protected]> * Added specs for neutron_conf (#161) * Puppetserver config spec (#162) * spec for puppetserver_config * delete wrong empty line * adding amq broker xml specs (#165) * Update and sign uploader.json * Added spec for command pcs_status (#163) * Update and sign uploader.json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json * change hostname to hostname -f * Add spec for subscription_manager_release_show (#155) * Specs for ovirt engine logs (#151) * Parser: RedHatInsights/insights-core#1336 * Plugin: RedHatInsights/insights-plugins#977 Signed-off-by: Sachin Patil <[email protected]> * Added specs for ls_lib_firmware (#153) * Added specs for ls_lib_firmware * Modified specs as per base class FileListing * Modified specs name * Apply filters and sign uploader[.v2].json * Update signature for uploader json * Add Json signature check jenkins job * Fix typo in json check * Fix another typo in json sig check * force gpg check on deploy * Add some garbage to jenkins to make sure it fails * add notify * remove debug * debug * add header * remove debug * Add spec for command systool_b_scsi_v (#158) * Specs for collect /etc/sysconfig/libvirt-guests (#160) * Parser PR: RedHatInsights/insights-core#1392 Signed-off-by: Sachin Patil <[email protected]> * Added specs for neutron_conf (#161) * Puppetserver config spec (#162) * spec for puppetserver_config * delete wrong empty line * adding amq broker xml specs (#165) * Update and sign uploader.json * Added spec for command pcs_status (#163) * Update and sign uploader.json * Spec for file /var/log/ceph/ceph.log (#168) * Update and sign uploader_json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json * change hostname to hostname -f * Add spec for subscription_manager_release_show (#155) * Specs for ovirt engine logs (#151) * Parser: RedHatInsights/insights-core#1336 * Plugin: RedHatInsights/insights-plugins#977 Signed-off-by: Sachin Patil <[email protected]> * Added specs for ls_lib_firmware (#153) * Added specs for ls_lib_firmware * Modified specs as per base class FileListing * Modified specs name * Apply filters and sign uploader[.v2].json * Update signature for uploader json * Add Json signature check jenkins job * Fix typo in json check * Fix another typo in json sig check * force gpg check on deploy * Add some garbage to jenkins to make sure it fails * add notify * remove debug * debug * add header * remove debug * Add spec for command systool_b_scsi_v (#158) * Specs for collect /etc/sysconfig/libvirt-guests (#160) * Parser PR: RedHatInsights/insights-core#1392 Signed-off-by: Sachin Patil <[email protected]> * Added specs for neutron_conf (#161) * Puppetserver config spec (#162) * spec for puppetserver_config * delete wrong empty line * adding amq broker xml specs (#165) * Update and sign uploader.json * Added spec for command pcs_status (#163) * Update and sign uploader.json * Spec for file /var/log/ceph/ceph.log (#168) * Update and sign uploader_json * Add memcached configuration files (#173) * Add memcached config * Update uploader.json * Update uploader.v2.json * Add spec for multipath_conf_initramfs (#171) * Update and sign uploader json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json * change hostname to hostname -f * Add spec for subscription_manager_release_show (#155) * Specs for ovirt engine logs (#151) * Parser: RedHatInsights/insights-core#1336 * Plugin: RedHatInsights/insights-plugins#977 Signed-off-by: Sachin Patil <[email protected]> * Added specs for ls_lib_firmware (#153) * Added specs for ls_lib_firmware * Modified specs as per base class FileListing * Modified specs name * Apply filters and sign uploader[.v2].json * Update signature for uploader json * Add Json signature check jenkins job * Fix typo in json check * Fix another typo in json sig check * force gpg check on deploy * Add some garbage to jenkins to make sure it fails * add notify * remove debug * debug * add header * remove debug * Add spec for command systool_b_scsi_v (#158) * Specs for collect /etc/sysconfig/libvirt-guests (#160) * Parser PR: RedHatInsights/insights-core#1392 Signed-off-by: Sachin Patil <[email protected]> * Added specs for neutron_conf (#161) * Puppetserver config spec (#162) * spec for puppetserver_config * delete wrong empty line * adding amq broker xml specs (#165) * Update and sign uploader.json * Added spec for command pcs_status (#163) * Update and sign uploader.json * Spec for file /var/log/ceph/ceph.log (#168) * Update and sign uploader_json * Add memcached configuration files (#173) * Add memcached config * Update uploader.json * Update uploader.v2.json * Add spec for multipath_conf_initramfs (#171) * Update and sign uploader json * Add Spec for sysconfig_prelink (#175) * Add specs for ipcs_m and ipcs_m_p (#174) * Fix woopsie spec to exit on 1st found matching file (#176) * Sign and update uploader[.v2].json * Sign uploader json
Included: