-
Notifications
You must be signed in to change notification settings - Fork 196
Parser for /etc/vmware-tools/tools.conf
#1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A configuration file parser based on IniConfigFile. I've also included doctest based on conversation in RedHatInsights#1080 Signed-off-by: Sachin Patil <[email protected]>
PaulWay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I think this is OK but I'd suggest an improvement to how the test data is set up in the examples.
|
|
||
| Examples: | ||
|
|
||
| >>> from insights.parsers.vmware_tools_conf import VMwareToolsConf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest removing this kind of test set-up code from the examples, as it's not really how a rule writer would use the parser. Instead, put the sample content as a separate section (headed 'Sample tools.conf file::' or similar), copy its content into the test file, and use the globs option to doctest.testmod to set an environment which contains a result object (preferably finding a better name for it :-) ) that can then be tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonus points will be awarded for having the same sample content in the parser documentation as the configuration text in the test module :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PaulWay I implemented your suggestion. Please have a look. I wish if can avoid duplicating sample content in docstring as well as in test. I looked into doctest.DocTestFinder() but as the doc says it looks for lines starting with >>> or ... I think it is not a good idea to include sample content as
>>> CONF = '''
... CONTENT
'''
Hence at this moment, I'm happy with current implementation that also test docstring within tests.
Included `glob` to match `Examples` in docstring. That should avoid setting up and context object in docstring itself. Signed-off-by: Sachin Patil <[email protected]>
Included `glob` to match `Examples` in docstring. Similar to RedHatInsights#1089 Signed-off-by: Sachin Patil <[email protected]>
* Parser for `/etc/vmware-tools/tools.conf` A configuration file parser based on IniConfigFile. I've also included doctest based on conversation in #1080 Signed-off-by: Sachin Patil <[email protected]> * Parser for `/etc/vmware-tools/tools.conf` Included `glob` to match `Examples` in docstring. That should avoid setting up and context object in docstring itself. Signed-off-by: Sachin Patil <[email protected]> (cherry picked from commit e2851ad)
* [ls_etc] Merged tests to docstring File `insights/parsers/tests/test_ls_etc.py` contains tests which can be test using `doctest`. This patch merges those tests into docstring. Signed-off-by: Sachin Patil <[email protected]> * [ls_etc] Merged tests to docstring File `insights/parsers/tests/test_ls_etc.py` contains tests which can be test using `doctest`. This patch merges those tests into docstring keeping unittests intact. Signed-off-by: Sachin Patil <[email protected]> * [ls_etc] Test docstring Included `glob` to match `Examples` in docstring. Similar to #1089 Signed-off-by: Sachin Patil <[email protected]> * [ls_etc] Test docstring Fixed missing `assert` Signed-off-by: Sachin Patil <[email protected]>
* [ls_etc] Merged tests to docstring File `insights/parsers/tests/test_ls_etc.py` contains tests which can be test using `doctest`. This patch merges those tests into docstring. Signed-off-by: Sachin Patil <[email protected]> * [ls_etc] Merged tests to docstring File `insights/parsers/tests/test_ls_etc.py` contains tests which can be test using `doctest`. This patch merges those tests into docstring keeping unittests intact. Signed-off-by: Sachin Patil <[email protected]> * [ls_etc] Test docstring Included `glob` to match `Examples` in docstring. Similar to #1089 Signed-off-by: Sachin Patil <[email protected]> * [ls_etc] Test docstring Fixed missing `assert` Signed-off-by: Sachin Patil <[email protected]> (cherry picked from commit 4fc87ce)
* JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]>
* JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]>
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json * change hostname to hostname -f * Add spec for subscription_manager_release_show (#155) * Specs for ovirt engine logs (#151) * Parser: RedHatInsights/insights-core#1336 * Plugin: RedHatInsights/insights-plugins#977 Signed-off-by: Sachin Patil <[email protected]> * Added specs for ls_lib_firmware (#153) * Added specs for ls_lib_firmware * Modified specs as per base class FileListing * Modified specs name * Apply filters and sign uploader[.v2].json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json * change hostname to hostname -f * Add spec for subscription_manager_release_show (#155) * Specs for ovirt engine logs (#151) * Parser: RedHatInsights/insights-core#1336 * Plugin: RedHatInsights/insights-plugins#977 Signed-off-by: Sachin Patil <[email protected]> * Added specs for ls_lib_firmware (#153) * Added specs for ls_lib_firmware * Modified specs as per base class FileListing * Modified specs name * Apply filters and sign uploader[.v2].json * Update signature for uploader json * Add Json signature check jenkins job * Fix typo in json check * Fix another typo in json sig check * force gpg check on deploy * Add some garbage to jenkins to make sure it fails * add notify * remove debug * debug * add header * remove debug * Add spec for command systool_b_scsi_v (#158) * Specs for collect /etc/sysconfig/libvirt-guests (#160) * Parser PR: RedHatInsights/insights-core#1392 Signed-off-by: Sachin Patil <[email protected]> * Added specs for neutron_conf (#161) * Puppetserver config spec (#162) * spec for puppetserver_config * delete wrong empty line * adding amq broker xml specs (#165) * Update and sign uploader.json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json * change hostname to hostname -f * Add spec for subscription_manager_release_show (#155) * Specs for ovirt engine logs (#151) * Parser: RedHatInsights/insights-core#1336 * Plugin: RedHatInsights/insights-plugins#977 Signed-off-by: Sachin Patil <[email protected]> * Added specs for ls_lib_firmware (#153) * Added specs for ls_lib_firmware * Modified specs as per base class FileListing * Modified specs name * Apply filters and sign uploader[.v2].json * Update signature for uploader json * Add Json signature check jenkins job * Fix typo in json check * Fix another typo in json sig check * force gpg check on deploy * Add some garbage to jenkins to make sure it fails * add notify * remove debug * debug * add header * remove debug * Add spec for command systool_b_scsi_v (#158) * Specs for collect /etc/sysconfig/libvirt-guests (#160) * Parser PR: RedHatInsights/insights-core#1392 Signed-off-by: Sachin Patil <[email protected]> * Added specs for neutron_conf (#161) * Puppetserver config spec (#162) * spec for puppetserver_config * delete wrong empty line * adding amq broker xml specs (#165) * Update and sign uploader.json * Added spec for command pcs_status (#163) * Update and sign uploader.json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json * change hostname to hostname -f * Add spec for subscription_manager_release_show (#155) * Specs for ovirt engine logs (#151) * Parser: RedHatInsights/insights-core#1336 * Plugin: RedHatInsights/insights-plugins#977 Signed-off-by: Sachin Patil <[email protected]> * Added specs for ls_lib_firmware (#153) * Added specs for ls_lib_firmware * Modified specs as per base class FileListing * Modified specs name * Apply filters and sign uploader[.v2].json * Update signature for uploader json * Add Json signature check jenkins job * Fix typo in json check * Fix another typo in json sig check * force gpg check on deploy * Add some garbage to jenkins to make sure it fails * add notify * remove debug * debug * add header * remove debug * Add spec for command systool_b_scsi_v (#158) * Specs for collect /etc/sysconfig/libvirt-guests (#160) * Parser PR: RedHatInsights/insights-core#1392 Signed-off-by: Sachin Patil <[email protected]> * Added specs for neutron_conf (#161) * Puppetserver config spec (#162) * spec for puppetserver_config * delete wrong empty line * adding amq broker xml specs (#165) * Update and sign uploader.json * Added spec for command pcs_status (#163) * Update and sign uploader.json * Spec for file /var/log/ceph/ceph.log (#168) * Update and sign uploader_json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json * change hostname to hostname -f * Add spec for subscription_manager_release_show (#155) * Specs for ovirt engine logs (#151) * Parser: RedHatInsights/insights-core#1336 * Plugin: RedHatInsights/insights-plugins#977 Signed-off-by: Sachin Patil <[email protected]> * Added specs for ls_lib_firmware (#153) * Added specs for ls_lib_firmware * Modified specs as per base class FileListing * Modified specs name * Apply filters and sign uploader[.v2].json * Update signature for uploader json * Add Json signature check jenkins job * Fix typo in json check * Fix another typo in json sig check * force gpg check on deploy * Add some garbage to jenkins to make sure it fails * add notify * remove debug * debug * add header * remove debug * Add spec for command systool_b_scsi_v (#158) * Specs for collect /etc/sysconfig/libvirt-guests (#160) * Parser PR: RedHatInsights/insights-core#1392 Signed-off-by: Sachin Patil <[email protected]> * Added specs for neutron_conf (#161) * Puppetserver config spec (#162) * spec for puppetserver_config * delete wrong empty line * adding amq broker xml specs (#165) * Update and sign uploader.json * Added spec for command pcs_status (#163) * Update and sign uploader.json * Spec for file /var/log/ceph/ceph.log (#168) * Update and sign uploader_json * Add memcached configuration files (#173) * Add memcached config * Update uploader.json * Update uploader.v2.json * Add spec for multipath_conf_initramfs (#171) * Update and sign uploader json
* spec_systemctl_show_smartpdc * spec for qpidd_conf * add filter to just get database parament * spec ls_var_run (#84) * spec for systemctl_show_smartpdc (#91) * Specs for qemu_xml (#96) * Parser: RedHatInsights/insights-core#1207 Signed-off-by: Sachin Patil <[email protected]> * Update uploader.json and uploader.v2.json - applied filters and signed * Update uploader.json * Update uploader.v2.json * Specs for /etc/vmware-tools/tools.conf * JIRA: https://projects.engineering.redhat.com/browse/INSPEC-30 * Parser: RedHatInsights/insights-core#1089 Signed-off-by: Sachin Patil <[email protected]> * Updating uploader.[v2.]?json and signatures * Add spec for httpd_conf from SCLs httpd24 and jbcs-httpd24 (#115) * This commit replaces PR #89 * New spec collect openshift_hosts (#101) * New spec collect openshift_hosts * Add new file * Update and sign uploader.json and uploader.v2.json * Added specs for more CPU related information (#122) RedHatInsights/insights-core#1253 * Modified uploader json for file /var/log/neutron/metadata-agent.log (#117) * Modified uploader json for file /var/log/neutron/metadata-agent.log * Modified uploader json for file /var/log/containers/neutron/metadata-agent.log * Updated pattern for metadata-agent.log file * spec for ls_var_lib_mongodb (#118) * Added specs for additional CPU control indicators (#124) RedHatInsights/insights-core#1276 * Specs for virsh_list_all (#108) * Parser: RedHatInsights/insights-core#1246 Signed-off-by: Sachin Patil <[email protected]> * Update and sign uploader.[v2].json * Adding /etc/insights-client/machine-id to collection (#128) * Adding /etc/insights-client/machine-id to collection * Sign uploader.json and uploader.v2.json * Add spec for parser dmsetup_info (#109) * Signing uploader.json updates * Uploader.json sign and update * Add redhattools pub key for gpg check * spec for ls_var_spool_clientmq (#112) * add postdrop filter to ls_usr_sbin (#111) * Modified uploader json for file /etc/neutron/metadata_agent.ini (#116) * Modified uploader json for file /etc/neutron/metadata_agent.ini * Modified uploader json for file /var/lib/config-data/neutron/etc/neutron/metadata_agent.ini * Updated uploader.json and uploader.v2.json to remove extra spaces * Added '[' filter to the parser for /etc/neutron/metadata_agent.ini * Updated files to remove extra changes * Add spec for saphostexec (#133) * New spec for SAP host_profile (#134) * Add lspci kernel spec and ss tupna spec (#141) * Add lspci kernel spec * This is an iterim change related to #110 * Add ss tupna comand for #126 * Sign new uploader.[v2.]json * spec for ls_var_spool_postfix_maildrop (#113) * spec for ls_var_spool_postfix_maildrop * Update uploader.json * Clean up and (hopefully) fix merge conflict * Jenkins retest Non-substantive test to attempt to get Jenkins resynced * Added front-end asset for ss -ntupa (#126) * Added front-end asset for ss -ntulpa * Modified specs * Modified specs * Modified specs as per review comments * Modified specs for single specs for two parsers * New spec collect init_process_cgroup (#140) * Add Spec for saphostctl_getcimobject_sapinstance (#138) * Apply spec filters * Sign json * Modified uploader json file for command /sbin/lspci -k (#110) * Modified uploader json file for command /sbin/lspci -k * Modified specs as per latest parser code * Modified specs as per latest parser code * Added spec changes as per discussion * Modified as per review comments * Restored removed changes * spec for foreman_tasks_config (#139) * spec for foreman_tasks_config * filter for foreman-tasks-config * Update spec for lvs_noheadings (#144) * Update spec for lvs_noheadings and lvs_noheadings_all * Remove the shouldn't be changed part * Add spec for ls_ocp_cni_openshift_sdn (#147) * Add spec for ls_ocp_cni_openshift_sdn * Change the symbolic name * Add spec for cpuset_cpus (#150) * Added specs for file openvswitch-agent.log (#149) * Update and Sign uploader.json * change hostname to hostname -f * Add spec for subscription_manager_release_show (#155) * Specs for ovirt engine logs (#151) * Parser: RedHatInsights/insights-core#1336 * Plugin: RedHatInsights/insights-plugins#977 Signed-off-by: Sachin Patil <[email protected]> * Added specs for ls_lib_firmware (#153) * Added specs for ls_lib_firmware * Modified specs as per base class FileListing * Modified specs name * Apply filters and sign uploader[.v2].json * Update signature for uploader json * Add Json signature check jenkins job * Fix typo in json check * Fix another typo in json sig check * force gpg check on deploy * Add some garbage to jenkins to make sure it fails * add notify * remove debug * debug * add header * remove debug * Add spec for command systool_b_scsi_v (#158) * Specs for collect /etc/sysconfig/libvirt-guests (#160) * Parser PR: RedHatInsights/insights-core#1392 Signed-off-by: Sachin Patil <[email protected]> * Added specs for neutron_conf (#161) * Puppetserver config spec (#162) * spec for puppetserver_config * delete wrong empty line * adding amq broker xml specs (#165) * Update and sign uploader.json * Added spec for command pcs_status (#163) * Update and sign uploader.json * Spec for file /var/log/ceph/ceph.log (#168) * Update and sign uploader_json * Add memcached configuration files (#173) * Add memcached config * Update uploader.json * Update uploader.v2.json * Add spec for multipath_conf_initramfs (#171) * Update and sign uploader json * Add Spec for sysconfig_prelink (#175) * Add specs for ipcs_m and ipcs_m_p (#174) * Fix woopsie spec to exit on 1st found matching file (#176) * Sign and update uploader[.v2].json * Sign uploader json
A configuration file parser based on IniConfigFile.
I've also included doctest based on conversation in #1080
Signed-off-by: Sachin Patil [email protected]