replace R_FINITE with c99's isfinite #7242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badasahog
requested review from
HughParsonage,
jangorecki and
MichaelChirico
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7242 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 81 81
Lines 15254 15254
=======================================
Hits 15070 15070
Misses 184 184 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit e44e72c Download link for the artifact containing the test results: ↓ atime-results.zip
|
|
The R_ macro expands to isfinite if it’s available or provides a fallback
if not. So this doesn’t really do anything
…On Thu, 7 Aug 2025 at 10:19 pm, github-actions[bot] < ***@***.***> wrote:
*github-actions[bot]* left a comment (Rdatatable/data.table#7242)
<#7242 (comment)>
- HEAD=stdisfinite stopped early for DT[by,verbose=TRUE] improved in
#6296
- HEAD=stdisfinite slower P<0.001 for memrecycle regression fixed in
#5463
[image: Comparison Plot]
<https://asset.cml.dev/c18736684764f8e87a6d65faccecdc0abb37929f?cml=png&cache-bypass=2dbdcea1-5915-4ced-8f47-757b0ec88272>
Generated via commit 99579c7
<99579c7>
Download link for the artifact containing the test results: ↓
atime-results.zip
<https://github.com/Rdatatable/data.table/actions/runs/16803850929/artifacts/3710112656>
Task Duration
R setup and installing dependencies 5 minutes and 8 seconds
Installing different package versions 10 minutes and 11 seconds
Running and plotting the test cases 2 minutes and 35 seconds
<https://camo.githubusercontent.com/868b9269ca9c91f1fe13dd0a31a06c3dbb6aa910f67299bb65c5ba79a8c4bb14/68747470733a2f2f636d6c2e6465762f77617465726d61726b2e706e672339393537396337326463303862623430616161353838643338363336303936613565343335333032>
—
Reply to this email directly, view it on GitHub
<#7242 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB54MDGMKEEN53SE45MZZND3MM75ZAVCNFSM6AAAAACDKY7QVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNRTHE2TENZXGM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
I wasn't aware of that, but we are compiling with c99, no? I think it's better to use standard C when possible, up to you tho. |
|
I think it is better to use R API, in case behavior changes in future we are protected. Also this change unnecessarily will introduce many conflicts... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isfiniteis likely faster, and also not opaque to the compiler, allowing for other optimizations.