Skip to content

aligned translated vignettes on current EN contents #7221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

aligned translated vignettes on current EN contents #7221

wants to merge 23 commits into from

Conversation

ChristianWia
Copy link
Contributor

global align of translated vignettes on current EN contents #7220

@ChristianWia ChristianWia requested a review from a team as a code owner July 28, 2025 13:44
@codecov Codecov
Copy link

codecov bot commented Jul 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (84b0e32) to head (3d78523).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7221   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          81       81           
  Lines       15215    15241   +26     
=======================================
+ Hits        15029    15055   +26     
  Misses        186      186

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tdhock
Copy link
Member

tdhock commented Jul 28, 2025

great, thanks! is this ready to merge?

@ChristianWia
Copy link
Contributor Author

great, thanks! is this ready to merge?

no no ! , postpone for later till all FR list is explored and checked

@tdhock
Copy link
Member

tdhock commented Jul 28, 2025

in that case please click Convert to draft on the right
image
and then when it is ready for us to review, convert back to regular PR.

@ChristianWia ChristianWia marked this pull request as draft July 28, 2025 17:14
@ChristianWia
Update datatable-secondary-indices-and-auto-indexing.Rmd #7220 realig…
5c0ed28 
…nent
@ChristianWia
Update datatable-secondary-indices-and-auto-indexing.Rmd #7220 align
fc7ba7f
@ChristianWia
Update datatable-secondary-indices-and-auto-indexing.Rmd #7220 realign
773b3ab
@ChristianWia
Update datatable-secondary-indices-and-auto-indexing.Rmd #7220 realign
fbd1953 
readability
@ChristianWia
Merge branch 'ChristianWia-patch-1' into ChristianWia-patch-1-1
6ef40ce
@ChristianWia
Update datatable-sd-usage.Rmd #7220 align
d0cfdf3 
based on:
 $  git diff 2f49a0d HEAD ./vignettes/datatable-sd-usage.Rmd
diff --git a/vignettes/datatable-sd-usage.Rmd b/vignettes/datatable-sd-usage.Rmd
index f005b15..426a5db 100644
@ChristianWia
Update datatable-reference-semantics.Rmd #7220 realign
0686af6 
based on:
$  git diff 2f49a0d HEAD ./vignettes/datatable-reference-semantics.Rmd
diff --git a/vignettes/datatable-reference-semantics.Rmd b/vignettes/datatable-reference-semantics.Rmd
index 0c55fc4..1271196 100644
@ChristianWia
Update datatable-programming.Rmd #7220 alignment
107f695 
based on : 

$ git diff 2f49a0d HEAD ./vignettes/datatable-programming.Rmd
diff --git a/vignettes/datatable-programming.Rmd b/vignettes/datatable-programming.Rmd
index 93c6dc5..34c6d77 100644
@ChristianWia
Update datatable-importing.Rmd #7220 alignment
4bfa7d4 
based on 
 git diff 2f49a0d HEAD ./vignettes/datatable-importing.Rmd
diff --git a/vignettes/datatable-importing.Rmd b/vignettes/datatable-importing.Rmd
index 21e42b6..8f07345 100644
@ChristianWia
Update datatable-keys-fast-subset.Rmd #7220 realignment
a114c44 
based on:
$ git diff 2f49a0d HEAD ./vignettes/datatable-keys-fast-subset.Rmd
diff --git a/vignettes/datatable-keys-fast-subset.Rmd b/vignettes/datatable-keys-fast-subset.Rmd
index d60552e..391b78d 100644
@ChristianWia
Update datatable-keys-fast-subset.Rmd MiB instead of Mib
db1b82d 
l 422 print(object.size(DT), units = "MiB") expected for correct vignette generation (knitr)
@ChristianWia
Update datatable-faq.Rmd #7220 realign
59a850d 
based on 👍 
$ git diff 2f49a0d HEAD ./vignettes/datatable-faq.Rmd
diff --git a/vignettes/datatable-faq.Rmd b/vignettes/datatable-faq.Rmd
index 4c6f4c6..474c5b5 100644
@ChristianWia
Update datatable-faq.Rmd align style options
29c3a7b
@ChristianWia
Update datatable-joins.Rmd #7220 aligned
fae27ca 
based on :

$ git diff 2f49a0d HEAD ./vignettes/datatable-joins.Rmd
diff --git a/vignettes/datatable-joins.Rmd b/vignettes/datatable-joins.Rmd
index b3b3059..3d7cf8c 100644
@ChristianWia
Update datatable-intro.Rmd #7220 realign
f42fc1b 
based on 

$ git diff 2f49a0d HEAD ./vignettes/datatable-intro.Rmd
diff --git a/vignettes/datatable-intro.Rmd b/vignettes/datatable-intro.Rmd
index a0ce8bf..cc8ffca 100644
@ChristianWia ChristianWia mentioned this pull request Jul 29, 2025
Open
@ChristianWia
Copy link
Contributor Author

alignment completes for all FR vignettes.Requesting pull.

@ChristianWia ChristianWia marked this pull request as ready for review July 29, 2025 13:34
tdhock
tdhock reviewed Jul 29, 2025
View reviewed changes
tdhock
tdhock reviewed Jul 29, 2025
View reviewed changes
tdhock
tdhock reviewed Jul 29, 2025
View reviewed changes
tdhock
tdhock requested changes Jul 29, 2025
View reviewed changes
Copy link
Member

@tdhock tdhock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, please make a few minor changes.

@ChristianWia
Update datatable-joins.Rmd correction FR data.table masculine
ff7cf7b 
   - Le *premier groupe* de colonnes du nouveau `data.table` vient de la table `x` .
   - Le *second groupe* de colonnes du nouveau `data.table` vient de la table `i`.
@ChristianWia
Update datatable-joins.Rmd #7221 line 171
d8a4c79 
line 171  remove confusing text  data.table
@ChristianWia
Update datatable-joins.Rmd #7221 line 172
285b152 
remove confusing text data.table for translations
@ChristianWia
Update datatable-reshape.Rmd #7221 line 145
f2ce1e7 
line 145 remove spaces at front of the successive lines
@ChristianWia
Update datatable-reshape.Rmd #7221 line 146
3d78523 
line 146 remove spaces at front of the successive lines
@ChristianWia
Copy link
Contributor Author

looks good overall, please make a few minor changes.

ok all suggested corrections applied - merci.

@MichaelChirico MichaelChirico added the translation issues/PRs related to message translation projects label Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdhock tdhock tdhock requested changes

@MichaelChirico MichaelChirico Awaiting requested review from MichaelChirico MichaelChirico is a code owner

Assignees
No one assigned
Labels
translation issues/PRs related to message translation projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristianWia @tdhock @MichaelChirico