[rocprofiler-sdk] rename librocprofv3-attach.so #1342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
meserve-amd
added
rocprofiler-sdk: Ready for 1st code review
and removed
documentation
meserve-amd
force-pushed
the
users/meserve-amd/attach/rocattach-rename
branch
from
7059074 to
f929080
Compare
github-actions
bot
added
documentation
bgopesh
force-pushed
the
users/meserve-amd/attach/doc_cleanup
branch
from
779a0ae to
1515bc5
Compare
meserve-amd
force-pushed
the
users/meserve-amd/attach/rocattach-rename
branch
from
f929080 to
e01b466
Compare
itrowbri
approved these changes
Oct 13, 2025
Contributor
itrowbri
left a comment
itrowbri
left a comment
There was a problem hiding this comment.
I'm not familiar with the component sections of the code, but the changes seem simple enough. Will we need to add some tests outside of the tests/rocprofv3 section if we formalize this change given that attachment won't be limited to rocprofv3 anymore?
Contributor
|
Please rename the library hardcoded in rocprofiler-compute at https://github.com/ROCm/rocm-systems/blob/develop/projects/rocprofiler-compute/src/rocprof_compute_profile/profiler_rocprofiler_sdk.py |
meserve-amd
added
changes requested
and removed
rocprofiler-sdk: Ready for 1st code review
labels
meserve-amd
force-pushed
the
users/meserve-amd/attach/doc_cleanup
branch
from
1515bc5 to
0914631
Compare
meserve-amd
force-pushed
the
users/meserve-amd/attach/rocattach-rename
branch
from
e01b466 to
4faac6b
Compare
vedithal-amd
approved these changes
Oct 14, 2025
jrmadsen
requested changes
Oct 21, 2025
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-rocattach/details/filesystem.hpp
Show resolved
Hide resolved
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-rocattach/rocattach.cpp
Show resolved
Hide resolved
meserve-amd
force-pushed
the
users/meserve-amd/attach/doc_cleanup
branch
from
0914631 to
89626a2
Compare
meserve-amd
force-pushed
the
users/meserve-amd/attach/doc_cleanup
branch
from
89626a2 to
7ef5c91
Compare
meserve-amd
force-pushed
the
users/meserve-amd/attach/rocattach-rename
branch
2 times, most recently
from
4b0ca98 to
e55bc1a
Compare
meserve-amd
force-pushed
the
users/meserve-amd/attach/doc_cleanup
branch
from
7ef5c91 to
fc03ac7
Compare
meserve-amd
force-pushed
the
users/meserve-amd/attach/rocattach-rename
branch
from
e55bc1a to
cd1a7c7
Compare
Base automatically changed from
users/meserve-amd/attach/doc_cleanup
to
develop
October 22, 2025 21:16
meserve-amd
force-pushed
the
users/meserve-amd/attach/rocattach-rename
branch
2 times, most recently
from
92434df to
2d55220
Compare
bwelton
requested changes
Oct 29, 2025
Contributor
bwelton
left a comment
bwelton
left a comment
There was a problem hiding this comment.
Fix the typo, may fix the tests as well.
projects/rocprofiler-sdk/cmake/rocprofiler_config_packaging.cmake
Outdated
Show resolved
Hide resolved
meserve-amd
force-pushed
the
users/meserve-amd/attach/rocattach-rename
branch
from
2d55220 to
87e4dd9
Compare
bwelton
approved these changes
Oct 30, 2025
jrmadsen
previously requested changes
Oct 30, 2025
projects/rocprofiler-sdk/source/docs/api-reference/process_attachment.rst
Outdated
Show resolved
Hide resolved
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-rocattach/ptrace_session.cpp
Show resolved
Hide resolved
ammarwa
force-pushed
the
users/meserve-amd/attach/rocattach-rename
branch
from
f6cd3a8 to
31de924
Compare
meserve-amd
force-pushed
the
users/meserve-amd/attach/rocattach-rename
branch
4 times, most recently
from
1c24012 to
13a5cdb
Compare
meserve-amd
dismissed
jrmadsen’s stale review
Comments have either been addressed or moved to #1653
- Renames library to librocprofiler-sdk-rocattach - ROCAttach library will be formalized and documented in future commit
- Rename rocprofv3-attach.py to rocprof-attach.py - Use common filesystem.hpp in rocattach
meserve-amd
force-pushed
the
users/meserve-amd/attach/rocattach-rename
branch
from
13a5cdb to
3c31971
Compare
Collaborator
|
psdb passing rocprofiler test -- override |
systems-assistant bot
pushed a commit
to ROCm/rocprofiler-compute
that referenced
this pull request
Nov 18, 2025
* attach: rename librocprofv3-attach - Renames library to librocprofiler-sdk-rocattach - ROCAttach library will be formalized and documented in future commit * Address review comments - Rename rocprofv3-attach.py to rocprof-attach.py - Use common filesystem.hpp in rocattach * Fix component name typo * Doc fixup [rocm-systems] ROCm/rocm-systems#1342 (commit 1271813)
systems-assistant bot
pushed a commit
to ROCm/rocprofiler-sdk
that referenced
this pull request
Nov 18, 2025
* attach: rename librocprofv3-attach - Renames library to librocprofiler-sdk-rocattach - ROCAttach library will be formalized and documented in future commit * Address review comments - Rename rocprofv3-attach.py to rocprof-attach.py - Use common filesystem.hpp in rocattach * Fix component name typo * Doc fixup [rocm-systems] ROCm/rocm-systems#1342 (commit 1271813)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In anticipation of formalizing an API for custom tools to attach with, we will rename librocprofv3-attach.so to librocprofiler-sdk-rocattach.so. This name was chosen because the library is technically not part of rocprofv3. We also anticipate formalizing and publishing a public API with this library, which we are calling ROCAttach. This API will be used by custom tools who wish to create their own attachment scenarios, so they do not need to learn the inner workings of ptrace or the protocol used to communicate with rocprofiler-sdk in the running process.
Technical Details
This PR is staged over a documentation change that I expect to be merged first.
I've kept just the rename separate for easier review and gitfu. Another review and documentation step for this API is to follow.
Test Plan
Use existing CI
Test Result
First result - failed due to incorrect naming of .so file, fixed this
Second result - some existing failures, need to fix before validating this change is ok
Submission Checklist