Rework helmfile dependencies during deployment #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@keyvaann For Kafka related services, we still have |
pvannierop
force-pushed
the
feature/needs-helmfile-rework
branch
2 times, most recently
from
c98535b to
3941841
Compare
Collaborator
|
If we have the |
Collaborator
|
You can remove the |
Collaborator
|
Why there are 2 helmfiles? |
Contributor
Author
|
This is to make sure that cert-manager is installed first. Cert-manager is needed to install many services and it would be very cumbersome declare it as needs in the 00-services.yaml. For cert-manager I rely on the glob order. |
keyvaann
force-pushed
the
feature/needs-helmfile-rework
branch
from
3941841 to
daa0dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the method by which dependencies are evaluated by helmfile is reworked. Instead of different helmfiles treated in sequence (00-init, 10-base, ...) there is one helmfile (sic, see next) where dependencies are declared with needs members. The only service that is created before all others is cert-manager (and prometheus); omitting this will cause other services to throw errors.