Use helmfile dependency management #241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Perhaps just add a line in README like |
pvannierop
reviewed
Jul 3, 2024
Contributor
pvannierop
left a comment
pvannierop
left a comment
There was a problem hiding this comment.
I think this is a very nice addition. I tested it myself and it works. However, I think it would be good to review the helmfiles again. I think that, for instance, in 20-dashboard.yaml the timescaledb is not covered by the 'needs:' sections.
Collaborator
Author
|
Changes applied in #306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently you can use helmfile to manage dependencies so we don't have to use --concurrency 1 flag anymore. However right now this assumes that all dependencies like Kafka, S3 and Postgresql are all installed on the cluster, this needs to be fixed before the PR is ready. However it's still possible to ignore dependency management system with --skip-needs flag.
Continued from #221