Skip to content

fix chat templating for llama hosted on bedrock #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 30, 2024
Merged

fix chat templating for llama hosted on bedrock #623

merged 9 commits into from
Sep 30, 2024

Conversation

narengogi
Copy link
Collaborator

@narengogi narengogi commented Sep 23, 2024 •
edited
Loading

Related Issues: (optional)

TODO:

  • Some more testing with llama models on bedrock

Testing Done:

  • Tested with combinations of various roles (system only, system and user, system, user and assistant alternating, non alternating)
  • verified against chat templates from meta and mistral

@VisargD VisargD merged commit 5de7fdf into Portkey-AI:main Sep 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VisargD VisargD VisargD approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@narengogi @VisargD