Skip to content

Conversation

@albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Sep 12, 2025

Context:

Blocks PennyLaneAI/catalyst#2041

Description of the Change:

The capture Device.setup_execution_config was about the capabilities of the capture execution pipeline, which is no longer maintained or actively developed. While I'm not sure where will be the best place for this logic in catalyst, we can leave that up to catalyst and no determine it in program capture.

Benefits:

Unblocks catalyst unification work.

Possible Drawbacks:

Related GitHub Issues:

[sc-99193]

Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.39%. Comparing base (a7986f3) to head (41a06ea).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8258      +/-   ##
==========================================
- Coverage   99.40%   99.39%   -0.01%     
==========================================
  Files         551      551              
  Lines       57214    57215       +1     
==========================================
  Hits        56871    56871              
- Misses        343      344       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@andrijapau andrijapau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@albi3ro albi3ro enabled auto-merge September 12, 2025 19:12
@albi3ro albi3ro added this pull request to the merge queue Sep 12, 2025
Merged via the queue into master with commit 2bc8aa4 Sep 12, 2025
54 checks passed
@albi3ro albi3ro deleted the capture-qnode-no-setup-execution-config branch September 12, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants