translate counts from plxpr #2041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Christina for adding this! let us know when it's ready for final review, but the changes look fine to me 👍 |
github-merge-queue bot
pushed a commit
to PennyLaneAI/pennylane
that referenced
this pull request
Sep 11, 2025
**Context:** Paired with catalyst PR: PennyLaneAI/catalyst#2041 **Description of the Change:** Just have `CountsMP._wires_primitive` return two abstract measurements, one for the keys, and one for the values. While this primitive will have no current implementation in PL, it can still be nicely translated by catalyst. **Benefits:** Program capture can more easily serve as frontend for catalyst. **Possible Drawbacks:** **Related GitHub Issues:** [sc-92900]
JerryChen97
reviewed
Sep 12, 2025
github-merge-queue bot
pushed a commit
to PennyLaneAI/pennylane
that referenced
this pull request
Sep 12, 2025
**Context:** Blocks PennyLaneAI/catalyst#2041 **Description of the Change:** The capture `Device.setup_execution_config` was about the capabilities of the capture execution pipeline, which is no longer maintained or actively developed. While I'm not sure where will be the best place for this logic in catalyst, we can leave that up to catalyst and no determine it in program capture. **Benefits:** Unblocks catalyst unification work. **Possible Drawbacks:** **Related GitHub Issues:** [sc-99193] --------- Co-authored-by: Andrija Paurevic <[email protected]>
github-merge-queue bot
pushed a commit
to PennyLaneAI/pennylane
that referenced
this pull request
Sep 12, 2025
**Context:** Blocks PennyLaneAI/catalyst#2041 **Description of the Change:** The capture `Device.setup_execution_config` was about the capabilities of the capture execution pipeline, which is no longer maintained or actively developed. While I'm not sure where will be the best place for this logic in catalyst, we can leave that up to catalyst and no determine it in program capture. **Benefits:** Unblocks catalyst unification work. **Possible Drawbacks:** **Related GitHub Issues:** [sc-99193] --------- Co-authored-by: Andrija Paurevic <[email protected]>
albi3ro
commented
Sep 15, 2025
Co-authored-by: Yushao Chen (Jerry) <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2041 +/- ##
==========================================
+ Coverage 97.37% 97.41% +0.03%
==========================================
Files 88 88
Lines 9980 10095 +115
Branches 945 951 +6
==========================================
+ Hits 9718 9834 +116
Misses 207 207
+ Partials 55 54 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Paul <[email protected]>
albi3ro
commented
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Depends on PennyLaneAI/pennylane#8229
Once that PR is merged and new pennylane wheels are up, we can version bump catalyst.
Description of the Change:
Translates counts from plxpr to catalxpr.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-99071]