Skip to content

Conversation

@westfish
Copy link
Contributor

@westfish westfish commented Dec 21, 2022

PR types

Function optimization

PR changes

Models

Description

升级SpanEvaluator,支持不同limit下的precision, recall and F1-score的评测。
升级后的SpanEvaluator不影响之前项目的使用,只是把其中get_bool_ids_greater_than隐藏的支持自定义limit的能力从上层释放了出来。

@paddle-bot
Copy link

paddle-bot bot commented Dec 21, 2022

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2022

CLA assistant check
All committers have signed the CLA.

@westfish westfish requested a review from wawltor December 21, 2022 13:22
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #4195 (78462c1) into develop (fcfe692) will decrease coverage by 0.15%.
The diff coverage is 14.60%.

@@             Coverage Diff             @@
##           develop    #4195      +/-   ##
===========================================
- Coverage    34.06%   33.91%   -0.16%     
===========================================
  Files          405      405              
  Lines        56613    56842     +229     
===========================================
- Hits         19288    19277      -11     
- Misses       37325    37565     +240     
Impacted Files Coverage Δ
paddlenlp/transformers/generation_utils.py 73.86% <ø> (ø)
...nlp/ops/faster_transformer/transformer/decoding.py 7.50% <7.65%> (-0.72%) ⬇️
...ster_transformer/transformer/faster_transformer.py 12.42% <15.00%> (+0.17%) ⬆️
paddlenlp/metrics/span.py 22.22% <28.57%> (-0.51%) ⬇️
paddlenlp/transformers/t5/modeling.py 85.28% <45.94%> (-1.67%) ⬇️
paddlenlp/utils/file_lock.py 78.00% <0.00%> (-10.00%) ⬇️
paddlenlp/utils/downloader.py 43.44% <0.00%> (-9.43%) ⬇️
paddlenlp/transformers/roberta/modeling.py 90.21% <0.00%> (+0.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@westfish westfish mentioned this pull request Dec 27, 2022
@westfish westfish self-assigned this Dec 27, 2022
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 520cb09 into PaddlePaddle:develop Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants