Skip to content

Conversation

@westfish
Copy link
Contributor

PR types

New features

PR changes

Models

Description

新增无监督问答

@paddle-bot
Copy link

paddle-bot bot commented Dec 21, 2022

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #4193 (f2db255) into develop (fcfe692) will increase coverage by 2.29%.
The diff coverage is 14.23%.

@@             Coverage Diff             @@
##           develop    #4193      +/-   ##
===========================================
+ Coverage    34.06%   36.36%   +2.29%     
===========================================
  Files          405      419      +14     
  Lines        56613    59169    +2556     
===========================================
+ Hits         19288    21514    +2226     
- Misses       37325    37655     +330     
Impacted Files Coverage Δ
paddlenlp/transformers/generation_utils.py 73.86% <ø> (ø)
...nlp/ops/faster_transformer/transformer/decoding.py 7.50% <7.65%> (-0.72%) ⬇️
...ster_transformer/transformer/faster_transformer.py 12.42% <15.00%> (+0.17%) ⬆️
paddlenlp/transformers/t5/modeling.py 85.28% <45.94%> (-1.67%) ⬇️
paddlenlp/__init__.py 19.76% <0.00%> (-10.54%) ⬇️
paddlenlp/trainer/trainer_utils.py 29.58% <0.00%> (-5.24%) ⬇️
paddlenlp/transformers/auto/modeling.py 71.88% <0.00%> (-4.98%) ⬇️
paddlenlp/experimental/ernie_model.py 32.43% <0.00%> (-0.91%) ⬇️
paddlenlp/metrics/span.py 22.22% <0.00%> (-0.51%) ⬇️
paddlenlp/transformers/model_utils.py 73.10% <0.00%> (-0.42%) ⬇️
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2022

CLA assistant check
All committers have signed the CLA.

@westfish westfish requested a review from wawltor December 21, 2022 13:22
@westfish westfish changed the title add uqa add unsupervised qa Dec 22, 2022
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议这些scrip删除

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的


import paddle
from evaluate import evaluate
from model import UIE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前 UIE已经集成到transformers里面 建议替换一下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的👌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

更新了UIE的调用方式,同时新增了新增uie-base-answer-extractor及uie-base-qa-filter模型权重
#4259

from paddlenlp.utils.tools import get_bool_ids_greater_than, get_span


class SpanEvaluator(Metric):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看看SpanEvaluator是不是已经集成到PaddleNLP,或者直接调库也能使用

Copy link
Contributor Author

@westfish westfish Dec 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,这个已经集成在paddlenlp.metrics,但是这里需要对SpanEvaluator做一下升级才可以,因为答案抽取的评估需要测试覆盖率,而SpanEvaluator当前没有这个能力,需要升级一下,我提了个PR #4195

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前已提前把这一块删除了

@westfish westfish self-assigned this Dec 27, 2022
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit c984ee7 into PaddlePaddle:develop Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants