Skip to content

[AutoParallel] fix grade_merge bug #68664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
+12 −0
Merged

[AutoParallel] fix grade_merge bug #68664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions python/paddle/distributed/passes/auto_parallel_gradient_merge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,18 @@ def _pir_append_gradient_merge_backward_op(
grad_defining_op.dist_attr.chunk_id,
)
)
# NOTE(zhangweilong): grad may in different device in auto_parallel, so need consider all_gather op
for used_grad_op in grad.all_used_ops():
if used_grad_op.name() != "pd_op.all_gather":
continue
move_to_opt_block_flag = True
for all_gather_result in used_grad_op.results():
for used_op in all_gather_result.all_used_ops():
if used_op.op_role != int(OpRole.Optimize):
move_to_opt_block_flag = False
break
if move_to_opt_block_flag:
used_grad_op.op_role = int(OpRole.Optimize)

opt_ops_use_grad = [
op
Expand Down