Skip to content

Conversation

@blacksheep-Aristotle
Copy link
Contributor

@blacksheep-Aristotle blacksheep-Aristotle commented Oct 12, 2024

PR Category

Auto Parallel

PR Types

Bug fixes

Description

在分布式情况下,梯度tensor可能会分布在不同的device上,所以在optimizer 对梯度做norm前可能需要allgather拿到完整的梯度。考虑到这种情况,需要将符合条件的all_gather op放到optimzier program里。
pcard-73145

@paddle-bot
Copy link

paddle-bot bot commented Oct 12, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@JZ-LIANG JZ-LIANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JZ-LIANG JZ-LIANG merged commit ab8d6b6 into PaddlePaddle:develop Oct 15, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants