Skip to content

Add multiprecision for adadelta op #50131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2023
Merged

Add multiprecision for adadelta op #50131

merged 3 commits into from
Mar 6, 2023

Conversation

@AnnaTrainingG
Copy link
Contributor

PR types

New features

PR changes

APIs

Describe

Add multiprecision for adadelta op

@paddle-bot
Copy link

paddle-bot bot commented Feb 1, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zkh2016
zkh2016 reviewed Feb 1, 2023
View reviewed changes
paddle/phi/ops/compat/adadelta_sig.cc Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里少了rho参数

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经添加

@AnnaTrainingG AnnaTrainingG force-pushed the op_adadelta branch 2 times, most recently from 7c0b454 to dd4598d Compare March 2, 2023 01:33
jiweibo
jiweibo previously approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@jiweibo jiweibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Dispensable of attr and inout

Shixiaowei02
Shixiaowei02 previously approved these changes Mar 2, 2023
View reviewed changes
@AnnaTrainingG AnnaTrainingG dismissed stale reviews from Shixiaowei02 and jiweibo via 5bbcb63 March 2, 2023 09:19
Shixiaowei02
Shixiaowei02 previously approved these changes Mar 3, 2023
View reviewed changes
jiweibo
jiweibo previously approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@jiweibo jiweibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for dispensable inout and default attr

@AnnaTrainingG AnnaTrainingG dismissed stale reviews from jiweibo and Shixiaowei02 via 2a8c08a March 3, 2023 02:49
@AnnaTrainingG AnnaTrainingG merged commit a8a2b7f into PaddlePaddle:develop Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zkh2016 zkh2016 zkh2016 approved these changes

@jiweibo jiweibo jiweibo approved these changes

@Shixiaowei02 Shixiaowei02 Shixiaowei02 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AnnaTrainingG @zkh2016 @jiweibo @Shixiaowei02