Skip to content

Add SVD Op and it's GPU and CPU kernel #34953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 2, 2021
Merged

Add SVD Op and it's GPU and CPU kernel #34953

merged 14 commits into from
Sep 2, 2021

Conversation

@2742195759
Copy link
Contributor

PR types

New features

PR changes

Ops

Describe

Add paddle.linalg.svd() function, Svd Op and Svd GPU/CPU kernel.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Aurelius84
Aurelius84 reviewed Aug 27, 2021
View reviewed changes
Aurelius84
Aurelius84 reviewed Aug 27, 2021
View reviewed changes
Aurelius84
Aurelius84 reviewed Aug 30, 2021
View reviewed changes
Aurelius84
Aurelius84 previously approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Aurelius84
Aurelius84 previously approved these changes Aug 31, 2021
View reviewed changes
zhangting2020
zhangting2020 previously approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@zhangting2020 zhangting2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for skip_check_grad_ci

zhiqiu
zhiqiu previously approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for const_cast and ShareDataWith

juncaipeng
juncaipeng previously approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@juncaipeng juncaipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op_threshold_white_list.py

@Aurelius84 Aurelius84 requested a review from zhiqiu September 1, 2021 02:24
juncaipeng
juncaipeng approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@juncaipeng juncaipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

phlrain
phlrain approved these changes Sep 1, 2021
View reviewed changes
Copy link
Collaborator

@phlrain phlrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for no_check_set

XiaoguangHu01
XiaoguangHu01 approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG API

cryoco
cryoco approved these changes Sep 1, 2021
View reviewed changes
Copy link

@cryoco cryoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM no_check_set

raindrops2sea
raindrops2sea reviewed Sep 2, 2021
View reviewed changes
Copy link
Member

@raindrops2sea raindrops2sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 7e5fb46 into PaddlePaddle:develop Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

@cryoco cryoco cryoco approved these changes

@zhangting2020 zhangting2020 zhangting2020 approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@phlrain phlrain phlrain approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@juncaipeng juncaipeng juncaipeng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.