Skip to content

Conversation

@jakpiase
Copy link
Contributor

PR types

New features

PR changes

OPs

Describe

Added slice BF16/FP32 FWD/BWD kernels.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@lidanqing-vv lidanqing-vv added this to the v2.2 milestone Aug 20, 2021
@lidanqing-vv
Copy link
Contributor

lidanqing-vv commented Aug 30, 2021

@sfraczek Hi, if you have time, Could you please help review? Thanks !

lidanqing-vv
lidanqing-vv previously approved these changes Aug 30, 2021
Copy link
Contributor

@lidanqing-vv lidanqing-vv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja requested a review from wozna August 30, 2021 08:09
wozna
wozna previously approved these changes Aug 30, 2021
Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments that are only related to factoring, so feel free to add that later. The rest LGTM.

@jakpiase jakpiase dismissed stale reviews from wozna and lidanqing-vv via 40b508b August 30, 2021 13:21
Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lidanqing-vv lidanqing-vv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants